fix: use ci or update for release checklist

Closes #260
npm · Nov 10, 2022 · 110b63a · 110b63a
1 parent e4465dd
commit 110b63a
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 6 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -168,7 +168,7 @@ jobs:
           RELEASE_COMMENT_ID: ${{ needs.release.outputs.comment-id }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |
-          npm exec --offline -- template-oss-release-manager
+          npm exec --offline -- template-oss-release-manager --lockfile=false
           npm run rp-pull-request --ignore-scripts -ws -iwr --if-present
       - name: Commit
         id: commit

diff --git a/bin/release-manager.js b/bin/release-manager.js
@@ -10,13 +10,19 @@ const log = (...logs) => console.error('LOG', ...logs)
 const ROOT = process.cwd()
 const pkg = require(join(ROOT, 'package.json'))
 
+const args = process.argv.slice(2).reduce((acc, a) => {
+  const [k, v] = a.replace(/^--/g, '').split('=')
+  acc[k] = v === 'true'
+  return acc
+}, {})
+
 /* eslint-disable max-len */
 const DEFAULT_RELEASE_PROCESS = `
 1. Checkout the release branch and test
 
     \`\`\`sh
     gh pr checkout <PR-NUMBER> --force
-    npm i
+    npm ${args.lockfile ? 'ci' : 'update'}
     npm test
     gh pr checks --watch
     \`\`\`

diff --git a/lib/content/release.yml b/lib/content/release.yml
@@ -82,7 +82,7 @@ jobs:
           RELEASE_COMMENT_ID: $\{{ needs.release.outputs.comment-id }}
           GITHUB_TOKEN: $\{{ secrets.GITHUB_TOKEN }}
         run: |
-          {{ rootNpmPath }} exec --offline -- template-oss-release-manager
+          {{ rootNpmPath }} exec --offline -- template-oss-release-manager --lockfile={{ lockfile }}
           {{ rootNpmPath }} run rp-pull-request --ignore-scripts {{~#if allFlags}} {{ allFlags }}{{else}} --if-present{{/if}}
       - name: Commit
         id: commit

diff --git a/tap-snapshots/test/apply/source-snapshots.js.test.cjs b/tap-snapshots/test/apply/source-snapshots.js.test.cjs
@@ -922,7 +922,7 @@ jobs:
           RELEASE_COMMENT_ID: \${{ needs.release.outputs.comment-id }}
           GITHUB_TOKEN: \${{ secrets.GITHUB_TOKEN }}
         run: |
-          npm exec --offline -- template-oss-release-manager
+          npm exec --offline -- template-oss-release-manager --lockfile=false
           npm run rp-pull-request --ignore-scripts --if-present
       - name: Commit
         id: commit
@@ -2392,7 +2392,7 @@ jobs:
           RELEASE_COMMENT_ID: \${{ needs.release.outputs.comment-id }}
           GITHUB_TOKEN: \${{ secrets.GITHUB_TOKEN }}
         run: |
-          npm exec --offline -- template-oss-release-manager
+          npm exec --offline -- template-oss-release-manager --lockfile=false
           npm run rp-pull-request --ignore-scripts -ws -iwr --if-present
       - name: Commit
         id: commit
@@ -3705,7 +3705,7 @@ jobs:
           RELEASE_COMMENT_ID: \${{ needs.release.outputs.comment-id }}
           GITHUB_TOKEN: \${{ secrets.GITHUB_TOKEN }}
         run: |
-          npm exec --offline -- template-oss-release-manager
+          npm exec --offline -- template-oss-release-manager --lockfile=false
           npm run rp-pull-request --ignore-scripts -ws -iwr --if-present
       - name: Commit
         id: commit