install/deps: Factor flatNameFromTree out of install/deps

PR-URL: #13692
Credit: @iarna
Reviewed-By: @zkat

Author: iarna

lib/install/deps.js

@@ -21,7 +21,7 @@ var inflateShrinkwrap = require('./inflate-shrinkwrap.js')
 var inflateBundled = require('./inflate-bundled.js')
 var andFinishTracker = require('./and-finish-tracker.js')
 var npm = require('../npm.js')
-var flatName = require('./flatten-tree.js').flatName
+var flatNameFromTree = require('./flatten-tree.js').flatNameFromTree
 var createChild = require('./node.js').create
 var resetMetadata = require('./node.js').reset
 var andIgnoreErrors = require('./and-ignore-errors.js')
@@ -468,14 +468,6 @@ var updatePhantomChildren = exports.updatePhantomChildren = function (current, c
   }
 }
 
-function flatNameFromTree (tree) {
-  validate('O', arguments)
-  if (tree.isTop) return '/'
-  var path = flatNameFromTree(tree.parent)
-  if (path !== '/') path += '/'
-  return flatName(path, tree)
-}
-
 exports._replaceModuleByPath = replaceModuleByPath
 function replaceModuleByPath (obj, key, child) {
   return replaceModule(obj, key, child, function (replacing, child) {

lib/install/flatten-tree.js

@@ -2,7 +2,11 @@
 var validate = require('aproba')
 var moduleName = require('../utils/module-name.js')
 
-module.exports = function (tree) {
+module.exports = flattenTree
+module.exports.flatName = flatName
+module.exports.flatNameFromTree = flatNameFromTree
+
+function flattenTree (tree) {
   validate('O', arguments)
   var seen = {}
   var flat = {}
@@ -24,7 +28,15 @@ module.exports = function (tree) {
   return flat
 }
 
-var flatName = module.exports.flatName = function (path, child) {
+function flatName (path, child) {
   validate('SO', arguments)
   return path + (moduleName(child) || 'TOP')
 }
+
+function flatNameFromTree (tree) {
+  validate('O', arguments)
+  if (tree.isTop) return '/'
+  var path = flatNameFromTree(tree.parent)
+  if (path !== '/') path += '/'
+  return flatName(path, tree)
+}