fix: preserve drive letter on windows git file:// urls

npm · Aug 21, 2019 · 3909203 · 3909203
1 parent a5a18b3
commit 3909203
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/npa.js b/npa.js
@@ -238,6 +238,11 @@ function fromURL (res) {
       } else {
         setGitCommittish(res, urlparse.hash != null ? urlparse.hash.slice(1) : '')
         urlparse.protocol = urlparse.protocol.replace(/^git[+]/, '')
+        if (urlparse.protocol === 'file:' && /^git\+file:\/\/[a-z]:/i.test(res.rawSpec)) {
+          // keep the drive letter : on windows file paths
+          urlparse.host += ':'
+          urlparse.hostname += ':'
+        }
         delete urlparse.hash
         res.fetchSpec = url.format(urlparse)
       }

diff --git a/test/windows.js b/test/windows.js
@@ -66,6 +66,21 @@ var cases = {
     rawSpec: '/foo/bar/baz',
     fetchSpec: '/foo/bar/baz',
     type: 'directory'
+  },
+  'foo@git+file://C:\\x\\y\\z': {
+    type: 'git',
+    registry: null,
+    where: null,
+    raw: 'foo@git+file://C:\\x\\y\\z',
+    name: 'foo',
+    escapedName: 'foo',
+    scope: null,
+    rawSpec: 'git+file://C:\\x\\y\\z',
+    saveSpec: 'git+file://C:\\x\\y\\z',
+    fetchSpec: 'file://c:/x/y/z',
+    gitRange: null,
+    gitCommittish: null,
+    hosted: null
   }
 }