From 7da45f87da65c859dc40a2bf3eea3d9da064f41d Mon Sep 17 00:00:00 2001 From: Gregor Date: Fri, 6 Oct 2017 12:21:51 -0700 Subject: [PATCH] build: ignore empty folders in test-addons Fixes: https://github.com/nodejs/node/issues/14843 PR-URL: https://github.com/nodejs/node/pull/16031 Reviewed-By: Myles Borins Reviewed-By: Michael Dawson Reviewed-By: Ben Noordhuis Reviewed-By: Anna Henningsen Reviewed-By: James M Snell --- Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Makefile b/Makefile index d917056b11ab82..56e7caef8332f1 100644 --- a/Makefile +++ b/Makefile @@ -267,7 +267,10 @@ test/addons/.buildstamp: config.gypi \ test/addons/.docbuildstamp # Cannot use $(wildcard test/addons/*/) here, it's evaluated before # embedded addons have been generated from the documentation. +# Ignore folders without binding.gyp (#14843) @for dirname in test/addons/*/; do \ + if [ ! -f "$$PWD/$${dirname}binding.gyp" ]; then \ + continue; fi ; \ printf "\nBuilding addon $$PWD/$$dirname\n" ; \ env MAKEFLAGS="-j1" $(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp \ --loglevel=$(LOGLEVEL) rebuild \