Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename which to node-which #67

Closed
wants to merge 2 commits into from
Closed

Rename which to node-which #67

wants to merge 2 commits into from

Conversation

radar
Copy link
Contributor

@radar radar commented Oct 15, 2019

Naming the executable of this library which can cause issues -- such as microsoft/vscode#82552.

I would like to suggest renaming this executable to node-which, so that people can clearly differentiate between built-in which (bash, zsh, etc) and the Node version.

@isaacs
Copy link
Contributor

isaacs commented Oct 16, 2019

I'm open to it. Need to also change the package.json file.

Naming the executable of this library `which` can cause issues -- such as microsoft/vscode#82552.

I would like to suggest renaming this executable to `node-which`, so that people can clearly differentiate between built-in `which` (bash, zsh, etc) and the Node version.
@radar
Copy link
Contributor Author

radar commented Oct 16, 2019

Thanks for being open to it! I've just changed package.json.

@radar
Copy link
Contributor Author

radar commented Oct 23, 2019

@isaacs is there anything else that I need to do for this PR?

@isaacs isaacs closed this in d65012c Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants