chore: ensure tests correctly mock environment variables before loading opts.js #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhei
approved these changes
Feb 13, 2025
Merged
owlstronaut
pushed a commit
that referenced
this pull request
Feb 18, 2025
🤖 I have created a release *beep* *boop* --- ## [6.0.2](v6.0.1...v6.0.2) (2025-02-18) ### Dependencies * [`618c70c`](618c70c) [#223](#223) remove promise-inflight (#223) ### Chores * [`29dfb33`](29dfb33) [#222](#222) ensure tests correctly mock environment variables before loading opts.js (#222) (@owlstronaut) * [`0fc4208`](0fc4208) [#220](#220) bump npm-package-arg from 11.0.3 to 12.0.1 (#220) (@dependabot[bot]) * [`52d8b0e`](52d8b0e) [#221](#221) bump @npmcli/template-oss from 4.23.3 to 4.24.1 (#221) (@dependabot[bot], @npm-cli-bot) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
t.mock()insidet.beforeEach()to ensureopts.jsreads the correctenvironment variables after
backupEnv()clears them. This prevents testsfrom failing locally due to pre-existing environment variables like
GIT_ASKPASS.I noticed while running the tests locally, mine was failing, but passing for the CI.