Fixes the failure to emit errors correctly

This was exposed by: npm/npm#7763

Author: iarna

index.js

@@ -39,18 +39,18 @@ function cleanup (er) {
   }.bind(this))
 }
 
-function cleanupSync (er) {
+function cleanupSync () {
   try {
     fs.unlinkSync(this.__atomicTmp)
   } finally {
-    return fs.WriteStream.prototype.emit.call(this, 'error', er)
+    return
   }
 }
 
 // When we *would* emit 'close' or 'finish', instead do our stuff
 WriteStream.prototype.emit = function (ev) {
   if (ev === 'error')
-    return cleanupSync(this)
+    cleanupSync.call(this)
 
   if (ev !== 'close' && ev !== 'finish')
     return fs.WriteStream.prototype.emit.apply(this, arguments)

test/toolong.js

@@ -0,0 +1,24 @@
+var path = require('path')
+var test = require('tap').test
+var writeStream = require('../index.js')
+
+function repeat(times, string) {
+  var output = ''
+  for (var ii = 0; ii < times; ++ii) {
+    output += string
+  }
+  return output
+}
+
+var target = path.resolve(__dirname, repeat(1000,'test'))
+
+test('name too long', function (t) {
+  var stream = writeStream(target)
+  stream.on('error', function (er) {
+    t.is(er.code, 'ENAMETOOLONG', target.length + " character name results in ENAMETOOLONG")
+  })
+  stream.on('close', function () {
+    t.end()
+  })
+  stream.end()
+})