Skip to content

Conversation

@audinue
Copy link

@audinue audinue commented Oct 9, 2018

This small pull request simply changes the warning message so that it will make more sense in the future 😄

Before

> npm -v
npm WARN npm npm does not support Node.js v10.11.0
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 4, 6, 7, 8, 9.
npm WARN npm You can find the latest version at https://nodejs.org/
6.4.1

The current version of node is v10.11.0 but should I upgrade to the newer 4, 6, 7, 8, 9? 😕

After

> npm -v
npm WARN npm npm does not support Node.js v10.11.0
npm WARN npm You should probably install the supported version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 4, 6, 7, 8, 9.
npm WARN npm You can find the latest version at https://nodejs.org/
6.4.1

@audinue audinue requested a review from a team as a code owner October 9, 2018 13:31
@ljharb
Copy link
Contributor

ljharb commented Oct 9, 2018

The logic in this file shouldn’t error for node v10.11, and node 10 and 11 are both listed in the list.

Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this makes more sense :)

@zkat zkat added the semver:patch semver patch level for changes label Nov 13, 2018
@zkat zkat changed the base branch from latest to release-next November 13, 2018 15:05
Co-Authored-By: audinue <audinue@gmail.com>
@audinue audinue closed this Nov 15, 2018
antongolub pushed a commit to antongolub-forks/npm-cli that referenced this pull request May 18, 2024
* chore: bump @npmcli/template-oss from 4.12.1 to 4.14.1

Bumps [@npmcli/template-oss](https://github.com/npm/template-oss) from 4.12.1 to 4.14.1.
- [Release notes](https://github.com/npm/template-oss/releases)
- [Changelog](https://github.com/npm/template-oss/blob/main/CHANGELOG.md)
- [Commits](npm/template-oss@v4.12.1...v4.14.1)

---
updated-dependencies:
- dependency-name: "@npmcli/template-oss"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore: postinstall for dependabot template-oss PR

* chore: postinstall for dependabot template-oss PR

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: npm CLI robot <npm-cli+bot@github.com>
Co-authored-by: nlf <quitlahok@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver:patch semver patch level for changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants