Merged
Conversation
Contributor
|
From what I saw, this will help the initialization like my refactoring for One thing that I noticed you didn't call the |
wraithgar
reviewed
Apr 10, 2024
4677f8b to
d162325
Compare
lukekarrys
commented
Apr 10, 2024
lukekarrys
commented
Apr 10, 2024
wraithgar
reviewed
Apr 11, 2024
wraithgar
reviewed
Apr 11, 2024
wraithgar
reviewed
Apr 11, 2024
wraithgar
reviewed
Apr 11, 2024
wraithgar
reviewed
Apr 11, 2024
wraithgar
reviewed
Apr 11, 2024
wraithgar
reviewed
Apr 11, 2024
wraithgar
reviewed
Apr 11, 2024
wraithgar
reviewed
Apr 11, 2024
wraithgar
reviewed
Apr 11, 2024
wraithgar
reviewed
Apr 11, 2024
wraithgar
reviewed
Apr 11, 2024
wraithgar
reviewed
Apr 11, 2024
wraithgar
reviewed
Apr 11, 2024
wraithgar
reviewed
Apr 11, 2024
wraithgar
reviewed
Apr 11, 2024
wraithgar
reviewed
Apr 11, 2024
8791b08 to
7bc5682
Compare
lukekarrys
commented
Apr 11, 2024
lukekarrys
commented
Apr 11, 2024
lukekarrys
commented
Apr 11, 2024
wraithgar
reviewed
Apr 11, 2024
…o it again in the future
The formatter will properly convert for logfiles
wraithgar
approved these changes
Apr 12, 2024
Member
wraithgar
left a comment
There was a problem hiding this comment.
Reviewed this while still in draft mode, and reviewed changes as we went.
I also triple checked that we really do only need to strip C0 and C1 from strings now.
Merged
Contributor
|
With this PR merged: $ hyperfine --warmup 3 "./bin/npm-cli.js run empty" "~/.asdf/installs/nodejs/21.6.2/bin/node ./bin/npm-cli.js run empty"
Benchmark 1: ./bin/npm-cli.js run empty
Time (mean ± σ): 155.1 ms ± 1.3 ms [User: 141.4 ms, System: 46.0 ms]
Range (min … max): 152.1 ms … 157.0 ms 19 runs
Benchmark 2: ~/.asdf/installs/nodejs/21.6.2/bin/node ./bin/npm-cli.js run empty
Time (mean ± σ): 77.2 ms ± 0.7 ms [User: 71.0 ms, System: 17.8 ms]
Range (min … max): 75.8 ms … 79.2 ms 38 runs
Summary
'~/.asdf/installs/nodejs/21.6.2/bin/node ./bin/npm-cli.js run empty' ran
2.01 ± 0.03 times faster than './bin/npm-cli.js run empty'Great work! |
This was referenced Apr 25, 2024
ljharb
referenced
this pull request
in ljharb/aud
May 22, 2024
1 task
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking remaining todos here:
display.js(was waiting for API to be stable enough)util.format