chore: fix tests for zlib differences between node versions #7040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
force-pushed
the
gar/zlib-tests
branch
from
5642e75 to
8202606
Compare
wraithgar
force-pushed
the
gar/zlib-tests
branch
from
8202606 to
eb185a6
Compare
wraithgar
force-pushed
the
gar/zlib-tests
branch
from
eb185a6 to
0aa966b
Compare
lukekarrys
approved these changes
Dec 1, 2023
|
Does this need to land first so other PRs will pass CI? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of npm's tests are built around the fact that zlib is not deterministic, but it looks like for some small code paths it had been so far and those tests were still using static fixtures. Enough changed in the latest node version to force the remaining tests we have w/ shasum fixtures to fail.
Good explanation at nodejs/node#50138