fix: unpublish bugfixes #7039
Merged
fix: unpublish bugfixes #7039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Properly work in workspace mode. Previously setting the workspace meant the entire package was unpublished. Now it follows the convention of acting as if you were running from the workspace directory. - Better checking of when you are unpublishing the last version of a package. npm checks the actual manifest and compares it to the version you are asking to unpublish. - Error on ranges and tags. npm doesn't unpublish ranges or tags, and giving those as inputs would give unexepected results. - Proper output of what was unpublished. Previously the package (and sometimes version) displayed would not match what was actually unpublished. - Updated docs specifying that unpublishing with no parameters will only unpublish the version represented by the local package.json
wraithgar
force-pushed
the
gar/workspace-unpublish
branch
from
3f47b3d
to
28536fb
Compare
lukekarrys
approved these changes
Dec 1, 2023
hashtagchris
reviewed
Dec 1, 2023
Comment on lines
+31
to
+33
| If you specify a package name but do not specify a version or if you | ||
| remove all of a package's versions then the registry will remove the | ||
| root package entry entirely. |
There was a problem hiding this comment.
Suggested change
| If you specify a package name but do not specify a version or if you | |
| remove all of a package's versions then the registry will remove the | |
| root package entry entirely. | |
| If you specify a package name but do not specify a version then the | |
| registry will remove the root package entry entirely. The same applies | |
| if you unpublish the last remaining version of a package. |
| let spec | ||
| if (args.length) { | ||
| spec = npa(args[0]) | ||
| if (spec.type !== 'version' && spec.rawSpec !== '*') { |
There was a problem hiding this comment.
spec.rawSpec !== '*'
💭 Looks like * is a specific case of a range spec. Would a isEntireRange method on the npm-package-arg response be useful, particularly if there's ever another rawSpec value that also selects the entire range?
There was a problem hiding this comment.
* is a special snowflake (no pun intended) within npm spec parsing and it always means "one version, the best version you can give me" npm 9 even had a breaking change where the few places we were NOT doing that (i.e. x and x@) now parse exactly as if you typed x@*.
| if (manifest?.name === spec.name && manifest.publishConfig) { | ||
| flatten(manifest.publishConfig, opts) | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggestion: Check pkgVersion and throw the Refusing to delete entire project usageError here, and get rid of the separate spec/non-spec checks above.
Merged
wraithgar
added a commit
that referenced
this pull request
Dec 1, 2023
- Properly work in workspace mode. Previously setting the workspace meant the entire package was unpublished. Now it follows the convention of acting as if you were running from the workspace directory. - Better checking of when you are unpublishing the last version of a package. npm checks the actual manifest and compares it to the version you are asking to unpublish. - Error on ranges and tags. npm doesn't unpublish ranges or tags, and giving those as inputs would give unexepected results. - Proper output of what was unpublished. Previously the package (and sometimes version) displayed would not match what was actually unpublished. - Updated docs specifying that unpublishing with no parameters will only unpublish the version represented by the local package.json
wraithgar
added a commit
that referenced
this pull request
Dec 1, 2023
- Properly work in workspace mode. Previously setting the workspace meant the entire package was unpublished. Now it follows the convention of acting as if you were running from the workspace directory. - Better checking of when you are unpublishing the last version of a package. npm checks the actual manifest and compares it to the version you are asking to unpublish. - Error on ranges and tags. npm doesn't unpublish ranges or tags, and giving those as inputs would give unexepected results. - Proper output of what was unpublished. Previously the package (and sometimes version) displayed would not match what was actually unpublished. - Updated docs specifying that unpublishing with no parameters will only unpublish the version represented by the local package.json
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
meant the entire package was unpublished. Now it follows the
convention of acting as if you were running from the workspace
directory.
package. npm checks the actual manifest and compares it to the
version you are asking to unpublish.
giving those as inputs would give unexepected results.
sometimes version) displayed would not match what was actually
unpublished.
only unpublish the version represented by the local package.json
Closes: #7015