Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to @npmcli/package-json #6472

Merged
merged 6 commits into from
May 22, 2023
Merged

Move to @npmcli/package-json #6472

merged 6 commits into from
May 22, 2023

Conversation

wraithgar
Copy link
Member

This PR is a series of commits that moves npm itself to use the
package.json parsing logic that was moved from read-package-json and
read-package-json-fast into @npmcli/package-json

It ends with the removal of the first two packages as direct dependents
of the cli. A bit more work needs to be done to remove their usage
elsewhere.

Some commands have tests that mock the library that parses package.json
and will need to be fixed before we can move them over
npm itself doesn't use it anymore in favor of @npmcli/package-json#prepare
@wraithgar wraithgar requested a review from a team as a code owner May 18, 2023 20:39
@wraithgar wraithgar self-assigned this May 18, 2023
npm itself doesn't use it anymore in favor of @npmcli/package-json#normalize
@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented May 18, 2023

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
show-version run-script
npm@9 51.479 ±4.46 23.498 ±0.02 22.758 ±0.09 25.432 ±0.60 3.513 ±0.03 3.550 ±0.07 3.118 ±0.01 15.935 ±0.14 2.949 ±0.03 4.448 ±0.01 0.476 ±0.01 0.506 ±0.01
#6472 54.219 ±3.26 24.043 ±0.34 25.127 ±2.14 26.204 ±0.40 3.634 ±0.14 3.609 ±0.10 3.163 ±0.07 16.443 ±0.41 3.037 ±0.06 4.672 ±0.41 0.466 ±0.00 0.530 ±0.01
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
show-version run-script
npm@9 36.310 ±0.87 17.862 ±0.20 17.379 ±0.11 18.797 ±0.52 3.207 ±0.02 3.212 ±0.02 3.063 ±0.06 11.680 ±0.02 2.841 ±0.02 3.948 ±0.01 0.449 ±0.01 0.489 ±0.01
#6472 37.130 ±1.78 18.182 ±0.15 17.640 ±0.09 18.676 ±0.67 3.223 ±0.00 3.292 ±0.02 3.102 ±0.06 11.935 ±0.07 2.927 ±0.03 3.991 ±0.00 0.463 ±0.01 0.525 ±0.01

@wraithgar wraithgar merged commit fc52ca8 into latest May 22, 2023
@wraithgar wraithgar deleted the gar/package-json branch May 22, 2023 15:48
@github-actions github-actions bot mentioned this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants