Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misleading on npm install with git url #64

Merged
merged 1 commit into from
Nov 13, 2018
Merged

Fix misleading on npm install with git url #64

merged 1 commit into from
Nov 13, 2018

Conversation

zckrs
Copy link
Contributor

@zckrs zckrs commented Aug 30, 2018

With some tests I note npm use default branch of repository instead of master.

@zckrs zckrs requested a review from a team as a code owner August 30, 2018 16:13
neverett
neverett reviewed Aug 31, 2018
View reviewed changes
doc/cli/npm-install.md Outdated Show resolved Hide resolved
Fix misleading on npm install with git url
7b31e31 
With some tests I note npm use default branch of repository instead of `master`.
@zckrs
Copy link
Contributor Author

zckrs commented Sep 12, 2018

Related to https://npm.community/t/npm-install-with-git-url-will-install-default-branch-instead-of-master-branch/1823/2

Can you merge?

zkat
zkat approved these changes Nov 13, 2018
View reviewed changes
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for catching this, and this should totally be the case now.

@zkat zkat changed the base branch from latest to release-next November 13, 2018 14:51
@zkat zkat merged commit bcae4ea into npm:release-next Nov 13, 2018
@zkat zkat added the docs label Nov 13, 2018
zkat pushed a commit that referenced this pull request Dec 10, 2018
@zkat
docs: clarify default branch with git url (#64)
274a3c2 
With some tests I note npm use default branch of repository instead of `master`.

PR-URL: #64
Credit: @zckrs
Reviewed-By: @zkat
@kevinjm39 kevinjm39 mentioned this pull request May 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neverett neverett neverett left review comments

@zkat zkat zkat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zckrs @zkat @neverett