readable-stream@3.0.2

[jmannanc]

Update readable-stream to fix this issue: https://npm.community/t/on-clean-node-v10-5-0-v10-6-0-and-v10-7-0-install-npm-install-yelds-asyncwrite-is-not-a-function-and-pna-nexttick-is-not-a-function/515/7

[zkat]

The reason we don't update readable-stream right now is because there needs to be a single copy of it in the entire tree, and there's a lot of packages that still rely on the legacy version. All those packages need to be updated (possibly with 2 || 3), or we'll get a ton more stuff in the tree, as you can see, and we'll still be running various bits of r-s@2. Not having a single copy also wreaks havoc in some places because it does instanceof checks and we do a lot of stream work :/

[jmannanc]

So if I go to those packages repos that depend on readable-stream and update it to 3.0.2 in a PR or something, then this could be merged? Along with updated versions of all the other packages that depend on readable-stream?

[zkat]

@sneakyfish5 if you do that, and it doesn't break anything else, then yes. Would be good to look into what the breaking changes actually are, too.

[jmannanc]

I can get to work on trying to update the packages that depend on readable-stream if you think 3.0.2 won't break anything. The breaking changes are here: https://github.com/nodejs/readable-stream#version-3xx

I don't know if any of them will apply to NPM, do you?

[zkat]

@SneakyFish I'm suspicious about at least 2, 4, 6, and 8. But the only way to really find out is to roll it out and see what happens.

[jmannanc]

Ok cool I'll get working on that then. Is there a way to mark this PR as WIP?

[isaacs]

readable-stream@3.3.0 will be in the next release.