fix: use hosted-git-info to parse registry urls#5758
Merged
Conversation
lukekarrys
force-pushed
the
lk/git-ssh-urls
branch
from
951d22e to
6a3688a
Compare
lukekarrys
changed the title
Contributor
Author
|
This change is located entirely within Converting this PR to a draft while I investigate further. |
This was referenced Oct 26, 2022
Contributor
Author
|
Falling back to |
Previously this was using `new URL` which would fail on some urls that `hosted-git-info` is able to parse. But if we still get a url that can't be parsed, we now set it to be removed from the tree instead of erroring. Fixes: #5278
lukekarrys
force-pushed
the
lk/git-ssh-urls
branch
from
c53f4a7 to
0483d10
Compare
wraithgar
approved these changes
Nov 1, 2022
Merged
This was referenced Nov 5, 2022
Merged
wraithgar
pushed a commit
that referenced
this pull request
Jun 10, 2025
…ls (#8356) When custom hosted git url are used to install dependencies it's not installing that dependency when the url is of `git+ssh://git@customgit.com:a/b/c.git` format instead of `git+ssh://git@customgit.com/a/b/c.git`. #### Cause: ` new URL(resolved)` throws an error which is getting caught and in-turn results in removal of that node. This behaviour was working as expected before this #8185 which replaced `hgi.parseUrl(resoved)` call to `new URL(resolved)` #### Fix: keep the `hgi.parseUrl` call to correctly parse the git url as mentioned/explained in this PR #5758 Fixes: #8331
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this was using
new URLwhich would fail on some urls thathosted-git-infois able to parse. But if we still get a url that can'tbe parsed, we now set it to be removed from the tree instead of
erroring.
Fixes: #5278
Closes: #5487