- 
                Notifications
    
You must be signed in to change notification settings  - Fork 3.8k
 
feat: refuse to set deprecated/invalid config #5719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | 
           Closes npm/statusboard#535  | 
    
33a7ddc    to
    146f0f8      
    Compare
  
    | 
           no statistically significant performance changes detected timing results
 
  | 
    
146f0f8    to
    4b87362      
    Compare
  
    BREAKING CHANGE: `npm config set` will no longer accept deprecated or invalid config options.
4b87362    to
    8a17f27      
    Compare
  
    
              
                    lukekarrys
  
              
              approved these changes
              
                  
                    Oct 19, 2022 
                  
              
              
            
            
    
  lukekarrys 
      pushed a commit
      that referenced
      this pull request
    
      Oct 19, 2022 
    
    
      
  
    
      
    
  
BREAKING CHANGE: `npm config set` will no longer accept deprecated or invalid config options.
  This was referenced Nov 5, 2022 
      
| 
           npm config set msvs_version not working  | 
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
BREAKING CHANGE:
npm config setwill no longer accept deprecated orinvalid config options.