Some typos #4849
Closed
Some typos #4849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typo fixed
wraithgar
reviewed
May 3, 2022
| @@ -36,7 +36,7 @@ in the current working directory if no package name is passed to the | |||
| subcommand. | |||
|
|
|||
| * public / restricted: | |||
| Set a package to be either publicly accessible or restricted. | |||
| Set a package to be either publicly-accessible or restricted. | |||
There was a problem hiding this comment.
I think the original was correct here.
wraithgar
reviewed
May 3, 2022
| @@ -70,4 +70,4 @@ npm <command> | |||
|
|
|||
| #### Is "npm" an acronym for "Node Package Manager"? | |||
|
|
|||
| Contrary to popular belief, **`npm`** **is not** in fact an acronym for "Node Package Manager"; It is a recursive bacronymic abbreviation for **"npm is not an acronym"** (if the project was named "ninaa", then it would be an acronym). The precursor to **`npm`** was actually a bash utility named **"pm"**, which was the shortform name of **"pkgmakeinst"** - a bash function that installed various things on various platforms. If **`npm`** were to ever have been considered an acronym, it would be as "node pm" or, potentially "new pm". | |||
| Contrary to popular belief, **`npm`** **is not** in fact an acronym for "Node Package Manager"; It is a recursive bacronymic abbreviation for **"npm is not an acronym"** (if the project was named "ninaa", then it would be an acronym). The precursor to **`npm`** was actually a bash utility named **"pm"**, which was the short form name of **"pkgmakeinst"** - a bash function that installed various things on various platforms. If **`npm`** were to ever have been considered an acronym, it would be as "node pm" or, potentially "new pm". | |||
There was a problem hiding this comment.
If anything this should be short-form
|
Neither of these seem to be correct typo fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some words on the readme and on the documentation
Like explained on top, the fixes that were done were only typos. Those are on
README.mdanddocs/content/commands/npm-access.mdI'll take a further look tomorrow, since right now is night time
Regards,
Rúben Costa