-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for installing instead of symlinking file:
dependencies
#4745
Conversation
9c1d7e0
to
c5adba2
Compare
file:
dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd really prefer if link:
is for symlinks and file:
is for copying files, like it used to be before npm 5 broke it, but another way to get file copying is still great
that would be great, but also a breaking change. i'd personally really like to see npm@9 go back to pack+install for |
… the Link target from the root
when set, installLinks instructs arborist to pack and extract a file: dependency rather than creating a symlink to it. this has the effect of also installing the dependencies for the linked dependency, though if local changes are made it also requires the user to reinstall the package
1765ead
to
cdec8eb
Compare
This looks great! 🎉 @nlf Does it close either #2239 or npm/rfcs#150? |
in theory, yes, but i didn't want it to automatically close the issues when it lands so i can follow up in both places |
Also perhaps related to @ljharb's comment: npm/feedback#667 |
this adds an
installLinks
flag to arborist, which when set instructs arborist to pack and extractfile:
links rather than creating a symlink to their directory. this also causes us to reify the dependencies of the directory.a follow up pull request will add the config definition and documentation for the flag.i changed my mind about a separate pull request, i'll be adding some commits to this one instead.for #2339
for npm/rfcs#150