feat(arborist): add named updates validation#4307
Merged
ruyadorno merged 2 commits intonpm:release-nextfrom Jan 26, 2022
Merged
feat(arborist): add named updates validation#4307ruyadorno merged 2 commits intonpm:release-nextfrom
ruyadorno merged 2 commits intonpm:release-nextfrom
Conversation
Arborist update does not support anything other than dependency names, that is confusing to some users that are used to provide semver ranges when using `npm install` and other commands. This changeset adds validation to the values provided as arguments in `npm update` and will throw a `EUPDATEARGS` error in case the user tries to use semver ranges, e.g: `npm update abbrev@1.0.0` Relates to: npm#4240
wraithgar
reviewed
Jan 24, 2022
wraithgar
approved these changes
Jan 24, 2022
Member
wraithgar
left a comment
wraithgar
left a comment
There was a problem hiding this comment.
Approved, with a small note about possibly changing the error message.
Contributor
Author
|
ok, pushed that error message change 😊 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arborist update does not support anything other than dependency names,
that is confusing to some users that are used to provide semver ranges
when using
npm installand other commands.This changeset adds validation to the values provided as arguments in
npm updateand will throw aEUPDATEARGSerror in case the user triesto use semver ranges, e.g:
npm update abbrev@1.0.0References
Relates to: #4240