Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isaacs/hide easter egg better #2743

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Isaacs/hide easter egg better #2743

merged 1 commit into from
Feb 22, 2021

Conversation

isaacs
Copy link
Contributor

@isaacs isaacs commented Feb 20, 2021

Got pinged about the overly "optimized" code in lib/birthday.js tripping some automated obfuscated code detection systems, which is fair.

If you're gonna hide a thing, hide it right, I guess.

Based on 2742, land that first.

@isaacs isaacs requested a review from a team as a code owner February 20, 2021 04:58
@isaacs isaacs requested a review from nlf February 20, 2021 05:00
@ljharb
Copy link
Contributor

ljharb commented Feb 20, 2021

lol how is that fair

@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release semver:patch semver patch level for changes labels Feb 22, 2021
@isaacs
Move implementation to separate package
ad4d12e 
PR-URL: #2743
Credit: @isaacs
Close: #2743
Reviewed-by: @nlf
@isaacs isaacs changed the base branch from latest to release/7.5.6 February 22, 2021 20:31
@isaacs isaacs force-pushed the isaacs/hide-easter-egg-better branch from 2225554 to ad4d12e Compare February 22, 2021 20:31
@isaacs isaacs merged commit ad4d12e into release/7.5.6 Feb 22, 2021
@nlf nlf deleted the isaacs/hide-easter-egg-better branch March 28, 2022 17:00
@Mhmonicox Mhmonicox mentioned this pull request Feb 15, 2023
Open
@jackromo888 jackromo888 mentioned this pull request Jun 27, 2023
Open
@Mary12jo33 Mary12jo33 mentioned this pull request Jun 29, 2023
Open
@NOUIY NOUIY mentioned this pull request Jun 29, 2023
Open
@CALISOULB CALISOULB mentioned this pull request Dec 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlf nlf nlf approved these changes

Assignees
No one assigned
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@isaacs @ljharb @nlf @darcyclarke