v6.10.3 #230
Merged
v6.10.3 #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #219 Credit: @claudiahdz Close: #219 Reviewed-by: @isaacs
Suggested by @godmar in https://npm.community/t/npm-err-cb-never-called-permission-denied/9167/5 Incidentally, this turned up that we're catching uncaughtExceptions in the main npm functions, but not unhandledRejections! Tracing this through, it seems like node-fetch-npm's use of cacache is particularly brittle. Any throw that comes from cacache is not caught properly, since node-fetch-npm is all streams and callbacks. The naive approach (just adding a catch and failing the callback) doesn't work, because then make-fetch-happen and npm-registry-fetch interpret the failure as an invalid response, when actually it was a local cache error. So, a bit more love and polish is definitely still needed in the guts of npm's fetching and caching code paths. In the meantime, though, handling any unhandledRejection at the top level prevents at least the worst and most useless type of error message. PR-URL: #227 Credit: @isaacs Close: #227 Reviewed-by: @isaacs
FEATURES * [bbcf7b2](npm/hosted-git-info@bbcf7b2) [#46](npm/hosted-git-info#46) [#43](npm/hosted-git-info#43) [#47](npm/hosted-git-info#47) [#44](npm/hosted-git-info#44) Add support for GitLab groups and subgroups ([@mterrel](https://github.com/mterrel), [@isaacs](https://github.com/isaacs), [@ybiquitous](https://github.com/ybiquitous)) BUGFIXES * ([3b1d629](npm/hosted-git-info@3b1d629)) [#48](npm/hosted-git-info#48) fix http protocol using sshurl by default ([@fengmk2](https://github.com/fengmk2)) * [5d4a8d7](npm/hosted-git-info@5d4a8d7) ignore noCommittish on tarball url generation ([@isaacs](https://github.com/isaacs)) * [1692435](npm/hosted-git-info@1692435) use gist tarball url that works for anonymous gists ([@isaacs](https://github.com/isaacs)) * [d5cf830](npm/hosted-git-info@d5cf830) * Do not allow invalid gist urls ([@isaacs](https://github.com/isaacs)) * [e518222](npm/hosted-git-info@e518222) Use LRU cache to prevent unbounded memory consumption ([@iarna](https://github.com/iarna))
isaacs
force-pushed
the
release-next-6.10.3
branch
from
4ee19e9
to
649e3c8
Compare
isaacs
force-pushed
the
release-next-6.10.3
branch
from
649e3c8
to
897537a
Compare
This was referenced Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v6.10.3 (2019-08-06):
BUGFIXES
27cccfbda#223 vulns → vulnerabilities in npm audit output (@sapegin)d5e865eb7#222 #226 install, doctor: don't crash if registry unset (@dmitrydvorkin, @isaacs)5b3890226#227 npm.community#9167 Handle unhandledRejections, tell user what to do when encountering anEACCESerror in the cache. (@isaacs)DEPENDENCIES
77516df6elicensee@7.0.3(@isaacs)ceb993590query-string@6.8.2(@isaacs)4050b9189hosted-git-info@2.8.23b1d629#48 fix http protocol using sshurl by default (@fengmk2)5d4a8d7ignore noCommittish on tarball url generation (@isaacs)1692435use gist tarball url that works for anonymous gists (@isaacs)d5cf830Do not allow invalid gist urls (@isaacs)e518222Use LRU cache to prevent unbounded memory consumption (@iarna)