Skip to content

fix: don't suppress run output when --silent is passed #1987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: don't suppress run output when --silent is passed #1987

wants to merge 1 commit into from

Conversation

@G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Oct 18, 2020

Restores the output of the command being run when using run-script, restoring the ability to use --silent to prevent showing npm ERR! output, as per the docs:

You can use the --silent flag to prevent showing npm ERR! output on error.

References

Fixes #1958

@G-Rath G-Rath requested a review from a team as a code owner October 18, 2020 19:55
@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release and removed release: next These items should be addressed in the next release labels Oct 20, 2020
@ruyadorno ruyadorno mentioned this pull request Oct 20, 2020
Merged
@ruyadorno ruyadorno closed this in 00d926f Oct 20, 2020
@G-Rath G-Rath deleted the dont-suppress-command-output-when-running branch October 20, 2020 19:20
@ruyadorno
Copy link
Contributor

ruyadorno commented Oct 20, 2020

Thanks for your contribution @G-Rath 🎉 Landed in v7.0.3

@ruyadorno ruyadorno mentioned this pull request Oct 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ruyadorno ruyadorno ruyadorno approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] --silent suppresses output from run commands

3 participants

@G-Rath @ruyadorno @darcyclarke