deps: float c2ccc1a on node-gyp #1974
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A change to "correctly rename object files for absolute paths" caused a bug in windows. A fix has already landed upstream in gyp-next, but has not yet made it's way to a release of gyp-next or to node-gyp. Let's float the change until it is fixed upstream. Refs: nodejs/gyp-next#74
MylesBorins
force-pushed
the
float-gyp-patch
branch
from
b0b0a64
to
73eff4c
Compare
darcyclarke
added
Release 7.x
|
Do folks have a preference between floating the single patch or the entire gyp-next 0.6.2 update? I have an open pr on node-gyp to update we could land instead |
MylesBorins
added a commit
to MylesBorins/cli
that referenced
this pull request
Oct 16, 2020
A change to "correctly rename object files for absolute paths" caused a bug in windows. A fix has already landed upstream in gyp-next and been release as 0.6.2, but has not yet made it's way to a release of node-gyp. This float the upgrade to 0.6.2 in node-gyp Closes: npm#1974 Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.6.2 Refs: nodejs/node-gyp#2241 Signed-off-by: Myles Borins <mylesborins@github.com>
|
I just opened #1976 as an alternative to this which includes the full update to gyp 0.6.2 |
Merged
ruyadorno
pushed a commit
that referenced
this pull request
Oct 16, 2020
A change to "correctly rename object files for absolute paths" caused a bug in windows. A fix has already landed upstream in gyp-next and been release as 0.6.2, but has not yet made it's way to a release of node-gyp. This float the upgrade to 0.6.2 in node-gyp Closes: #1974 Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.6.2 Refs: nodejs/node-gyp#2241 Signed-off-by: Myles Borins <mylesborins@github.com> PR-URL: #1976 Credit: @MylesBorins Close: #1976 Reviewed-by: @ruyadorno
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change to "correctly rename object files for absolute paths"
caused a bug in windows. A fix has already landed upstream in
gyp-next, but has not yet made it's way to a release of gyp-next
or to node-gyp.
Let's float the change until it is fixed upstream.
Refs: nodejs/gyp-next#74