Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

view: always fetch fullMetadata, and preferOnline #1757

Closed
wants to merge 1 commit into from
Closed

view: always fetch fullMetadata, and preferOnline #1757

wants to merge 1 commit into from

Conversation

isaacs
Copy link
Contributor

@isaacs isaacs commented Sep 2, 2020

@isaacs isaacs requested a review from a team as a code owner September 2, 2020 17:36
MylesBorins
MylesBorins approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

isaacs added a commit that referenced this pull request Sep 4, 2020
@isaacs
view: always fetch fullMetadata, and preferOnline
ef8f567 
PR-URL: #1757
Credit: @isaacs
Close: #1757
Reviewed-by: @ruyadorno
@darcyclarke darcyclarke added the Release 7.x work is associated with a specific npm 7 release label Sep 4, 2020
@isaacs isaacs closed this Sep 4, 2020
@isaacs isaacs deleted the isaacs/view-fixups branch October 2, 2020 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MylesBorins MylesBorins MylesBorins approved these changes

@ruyadorno ruyadorno ruyadorno approved these changes

Assignees
No one assigned
Labels
Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@isaacs @ruyadorno @MylesBorins @darcyclarke