Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update npm audit 401 error message #112

Closed
wants to merge 6 commits into from
Closed

Update npm audit 401 error message #112

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5f84b90
deps: fix licensee dep
zkat Dec 5, 2018
85d6a25
deps: reinstall licensee to diagnose issue
zkat Dec 5, 2018
9c05606
Account for 401 in audit
simonua Dec 11, 2018
5b119cd
Merge remote-tracking branch 'npm/release-next' into release-next
simonua Dec 13, 2018
795773a
Merge branch 'release-next' into feature/update-npm-audit-401-error-m…
simonua Dec 13, 2018
dbd2822
Clean up based on latest npm reorganization
simonua Dec 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/audit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,10 @@ function auditCmd (args, cb) {
}).then((auditReport) => {
return audit.submitForFullReport(auditReport)
}).catch((err) => {
if (err.statusCode === 404 || err.statusCode >= 500) {
// Some 3rd Party registries such as Microsoft Azure DevOps do not presently support `npm audit`. As no token is passed for `audit` and the registry may not
// have an exception in place for audit, a 401 is returned, which informs the user of an authentication-related issue that really masks a lack of implementation.
// Therefore, the custom error message now also triggers for 401s.
if (err.statusCode === 401 || err.statusCode === 404 || err.statusCode >= 500) {
const ne = new Error(`Your configured registry (${opts.registry}) does not support audit requests.`)
ne.code = 'ENOAUDIT'
ne.wrapped = err
Expand Down