Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE(arborist) log warning when saving lockfile lacking resolved/integrity for non-bundled dependencies #4280

Open
isaacs opened this issue May 2, 2021 · 1 comment
Open

FEATURE(arborist) log warning when saving lockfile lacking resolved/integrity for non-bundled dependencies #4280

isaacs opened this issue May 2, 2021 · 1 comment
Labels
Enhancement new feature or improvement ws:arborist Related to the arborist workspace

Comments

@isaacs
Copy link
Contributor

isaacs commented May 2, 2021

From npm/arborist#270

Reproduction case:

# reify to build package tree in node_modules
arborist reify

# remove all metadata about resolved/integrity
rm package-lock.json node_modules/.package-lock.json

# reify again to create a lockfile without full metadata
arborist reify # <-- this should warn
@isaacs
Copy link
Contributor Author

isaacs commented May 2, 2021

Note: bundled deps should never have resolved/integrity values, because they weren't fetched by us, and can be literally anything.

@fritzy fritzy transferred this issue from npm/arborist Jan 20, 2022
@fritzy fritzy added Needs Triage needs review for next steps ws:arborist Related to the arborist workspace labels Jan 20, 2022
@fritzy fritzy changed the title FEATURE: log warning when saving lockfile lacking resolved/integrity for non-bundled dependencies FEATURE(arborist) log warning when saving lockfile lacking resolved/integrity for non-bundled dependencies Jan 20, 2022
@ruyadorno ruyadorno added Enhancement new feature or improvement and removed Needs Triage needs review for next steps labels Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement new feature or improvement ws:arborist Related to the arborist workspace
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@isaacs @fritzy @ruyadorno