Skip to content

fix: Unnecessary variables and ESLint errors  #3453

Closed
@Ivan12273

Description

Hi, while I was reading the code I found that there are variables that are never used:

image

In the file ls.js the function getChildren do a filter by the selected workspaces an other by edges types if shouldSkipChildren is false.

The function "filterByEdgesTypes" filter debs by type and allows for: npm ls [--dev, --prod, --link, etc.]

image

But the variables node and tree are never used by this function.

Also, the npx-cli.js file have problems related to ESLint style.

In order to prevent future errors and have a more clear code, if there is no problem, I will submit a pull request with the changes I did :)

Metadata

Assignees

No one assigned

    Labels

    💎 Free Internet Points 💎similar to "Good First issue" - although more impactfulEnhancementnew feature or improvementGood First Issuegood issue or PR for newcomerssemver:patchsemver patch level for changes

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions