[BUG] failed to resolve peer dependencies (conflict) when peer dependencies are in range. #3152

talsi · 2021-04-26T15:44:59Z

Current Behavior:

npm install favors getting higher versions of peer dependencies.

for example:

"@angular/cdk": 10.2.5 has the following peer dependencies

{
  ...
  "@angular/common": "^10.0.0 || ^11.0.0-0",
  "@angular/core": "^10.0.0 || ^11.0.0-0"
  ...
}

"@angular/forms": 10.2.5 has the following peer dependencies

{
  ...
  "@angular/common": "10.2.5",
  "@angular/core": "10.2.5"
  ...
}

if you try to install both packages above you'll get an error because when resolving peer dependencies it chooses "@angular/common": 11.2.11 (and then "@angular/core": 11.2.11) thus results in a conflict

Expected Behavior:

when resolving peer dependencies it should choose "@angular/common": 10.2.5 (and then "@angular/core": 10.2.5) that would have satisfy all deps

Steps To Reproduce:

open an empty project / folder
run npm init (package.json doesn't list any dependencies)
run npm i @angular/cdk@10.2.5 @angular/forms@10.2.5

result:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! Found: @angular/core@11.2.11
npm ERR! node_modules/@angular/core
npm ERR!   peer @angular/core@"^10.0.0 || ^11.0.0-0" from @angular/cdk@10.2.5
npm ERR!   node_modules/@angular/cdk
npm ERR!     @angular/cdk@"10.2.5" from the root project
npm ERR!   peer @angular/core@"11.2.11" from @angular/common@11.2.11
npm ERR!   node_modules/@angular/common
npm ERR!     peer @angular/common@"^10.0.0 || ^11.0.0-0" from @angular/cdk@10.2.5
npm ERR!     node_modules/@angular/cdk
npm ERR!       @angular/cdk@"10.2.5" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! @angular/forms@"10.2.5" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: @angular/core@10.2.5
npm ERR! node_modules/@angular/core
npm ERR!   peer @angular/core@"10.2.5" from @angular/forms@10.2.5
npm ERR!   node_modules/@angular/forms
npm ERR!     @angular/forms@"10.2.5" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Environment:

npm: 7.11.1

The text was updated successfully, but these errors were encountered:

nlf · 2021-04-26T16:15:37Z

this is one we intend to resolve in some fashion, but it is surprisingly complicated with the current state of arborist.

as a work around for now you can specify @angular/common@10.2.5 as a direct dependency and you'll at least be unblocked and able to install your tree.

talsi · 2021-04-26T19:18:30Z

@nlf thanks, i really appreciate your suggestion for a workaround but this is merely an example to demonstrate the nature of the issue.

The real issue I'm facing is more complicated than the example above- i actually want to rely on npm to install peer dependencies correctly and to fail when it finds conflicts.

There are however many published libraries that will fail to install without a workaround.
There are also many CLIs and other tools that will not work because of this issue.

nlf · 2021-04-26T19:20:20Z

yup, totally understood. we're working on it but this one creates a huge amount of complexity so it may be some time before we come up with a solution that resolves as many conflicts as it possibly can without introducing massive slow downs.

In cases where a peerSet _partially_ overlaps another, we were previously treating that as a conflict, because not everything in the peerSet was being replaced. So for example, ``` root -> (a) a -> PEER(w@1, x@1, y@1) b -> PEER(x@1.0, y@1.0, z@1.0) ``` First we install, and get `w@1.1.0`, `x@1.1.0` and `z@1.1.0`. Then, we try to install `b`, and need to install the `1.0.0` versions of `x` and `y`. We could replace `x` and `y`, but then `z` had no replacement, and was treated as an ERESOLVE mistakenly. Some work was required to make it still note when a not-replaced member of the peer set _is_ indicative of a conflict, because it depends on a version of a dep within the peer set that is not satisfied by the one being replaced. Fix: npm/cli#3152

princemaple · 2021-05-02T00:22:46Z

Hey @talsi , does npm 7.11.2 work for you?
I'm still getting the same errors.

talsi · 2021-05-02T08:47:22Z

@princemaple

hi,
npm 7.11.2 does fixes the bug described above (successfully running npm i @angular/cdk@10.2.5 @angular/forms@10.2.5), but unfortunately, i'm still having a similar issue.

for example,
when trying to install @angular-slider/ngx-slider@"^2.0.3" and @angular/common@"^10.2.4"

@angular-slider/ngx-slider@"2.0.3" has a peer-dependency on @angular/common@">=6.1.0"
it chooses @angular/common@"10.2.5" that satisfies the root dependency of @angular/common@"^10.2.4"
@angular-slider/ngx-slider@"2.0.3" has a peer-dependency on @angular/forms@">=6.1.0"
it favors the higher version (11.2.12) of @angular/forms which has a peer-dependency on @angular/common@"11.2.12"

steps to reproduce are:
running npm i @angular-slider/ngx-slider@"^2.0.3" @angular/common@"^10.2.4"

result:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: untitled45@1.0.0
npm ERR! Found: @angular/common@10.2.5
npm ERR! node_modules/@angular/common
npm ERR!   @angular/common@"^10.2.4" from the root project
npm ERR!   peer @angular/common@">=6.1.0" from @angular-slider/ngx-slider@2.0.3
npm ERR!   node_modules/@angular-slider/ngx-slider
npm ERR!     @angular-slider/ngx-slider@"^2.0.3" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"11.2.12" from @angular/forms@11.2.12
npm ERR! node_modules/@angular/forms
npm ERR!   peer @angular/forms@">=6.1.0" from @angular-slider/ngx-slider@2.0.3
npm ERR!   node_modules/@angular-slider/ngx-slider
npm ERR!     @angular-slider/ngx-slider@"^2.0.3" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

@isaacs, @nlf,
should i open a new bug for it?

princemaple · 2021-05-03T23:14:00Z

#3171

This is because we are installing directly from git instead of via npmjs.com so we need to make sure that npm builds the libraries af- ter installing. The caveat is that we need to use --legacy-peer-deps when building md-menu because of some bug in npm that causes it to prefer higher versions when range is given: > npm ERR! Could not resolve dependency: > npm ERR! peer @angular/common@"10.2.5" from @angular/forms@10.2.5 > npm ERR! node_modules/@angular/forms > npm ERR! peer @angular/forms@"^9.0.0 || ^10.0.0-0" from @angular/material@9.2.4 > npm ERR! node_modules/@angular/material > npm ERR! peer @angular/material@">=7.0.0 <10.0.0" from the root project See: npm/cli#3152

This is because we are installing directly from git instead of via npmjs.com so we need to make sure that npm builds the libraries af- ter installing. The caveat is that we need to use --legacy-peer-deps when building md-menu because of some bug in npm that causes it to prefer higher versions when range is given: > npm ERR! Could not resolve dependency: > npm ERR! peer @angular/common@"10.2.5" from @angular/forms@10.2.5 > npm ERR! node_modules/@angular/forms > npm ERR! peer @angular/forms@"^9.0.0 || ^10.0.0-0" from @angular/material@9.2.4 > npm ERR! node_modules/@angular/material > npm ERR! peer @angular/material@">=7.0.0 <10.0.0" from the root project Also, it seems the npm postinstall was not necessary. See: npm/cli#3152

We need this because we are installing directly from git instead of via npmjs.com so we need to make sure that npm builds the libraries after installing. The caveat is that we need to use --legacy-peer-deps when building md-menu because of some bug in npm that causes it to prefer higher versions when range is given (we have @angular/forms@^9.0.0...): > npm ERR! Could not resolve dependency: > npm ERR! peer @angular/common@"10.2.5" from @angular/forms@10.2.5 > npm ERR! node_modules/@angular/forms > npm ERR! peer @angular/forms@"^9.0.0 || ^10.0.0-0" from @angular/material@9.2.4 > npm ERR! node_modules/@angular/material > npm ERR! peer @angular/material@">=7.0.0 <10.0.0" from the root project Also, it seems the npm postinstall was not necessary. See: npm/cli#3152

talsi · 2021-11-08T16:38:38Z

@isaacs it still happens to me using 7.24.2

talsi · 2021-11-08T16:40:23Z

@isaacs @nlf it still happens to me using 7.24.2

Quazmoz · 2022-02-08T00:58:04Z

Has there been any progress on this issue?

ljharb · 2022-02-08T01:00:20Z

@Quazmoz it's fixed. try npm 8 latest, and if you're getting an error like the above, then it means your dependency graph is invalid, and the error message explains why.

talsi · 2022-02-09T16:55:22Z

@Quazmoz @ljharb
actually this bug is not fixed and it's very easy to see it, just run
npm i @angular-slider/ngx-slider@"^2.0.3" @angular/common@"^10.2.4"
here's the output of the running it using the latest version (8,4,1)

the dependency graph is OK.
during install npm choose the highest version possible of @angular/forms instead of choosing a compatible version which would satisfy peer dependencies.
this bug is repeatedly getting closed. it doesn't seem like anyone thinks it's too serious.

ljharb · 2022-02-09T17:05:21Z

@talsi it's not always going to be possible (in a P=NP sense) to pick the right version; it's not really a bug that sometimes you have to do it yourself and explicitly add a peer dep (all your peer deps should be explicitly added anyways).

It seems like your project already depends on v13.2.2 of @angular/forms, and npm (correctly) respects that and does not downgrade it (because that might break your code, if you depend in a feature added in v13.2.0, for example).

I think you need to downgrade @angular/forms yourself, and then npm will be able to figure out the rest.

talsi · 2022-02-09T18:23:35Z

@ljharb
hi, my project is not dependent on anything. In fact, it's a fresh, completely empty project. No package-lock.json. No node_modules folder. No other dependencies in package.json. so npm choose to install an incompatible version of @angular/forms.

I can't control the peer dependencies of 3rd party libs.

If the default settings in npm 7 is to install peer dependencies then it shoud work flawlessly. That's the reason why it was removed after version 3.

For experienced developers this can be just a minor issue but new ones will immediately start using yarn or anything else that works for them.

I truly understand the complexity of this issue i just think that if there are no plans to fix this issue maybe it'll better to have users opt-in to use this feature instead of closing all of the bugs users open about it and keeping it as the the default setting.

I honstly don't understand how come this issue don't get more attention.

ljharb · 2022-02-09T19:00:09Z

@talsi indeed, you can't. which is why in this case you'd need to add @angular/forms to your initial npm install command. It's not possible for it to work flawlessly; but this is still an improvement over npm 6's behavior.

faizaldong · 2022-06-08T03:37:36Z

why this issue is closed? it still happening in June 2022 @ljharb

mshakibdev · 2022-06-27T11:42:07Z

I am still facing this issue.

ljharb · 2022-06-27T15:43:51Z

@faizaldong because the bug is likely in your package.json, not in npm

talsi added Bug thing that needs fixing Needs Triage needs review for next steps Release 7.x work is associated with a specific npm 7 release labels Apr 26, 2021

This was referenced Apr 26, 2021

[BUG] peer-dependency conflict when having "greater than or equal to" range >= #2553

Closed

fix: correctly handle peer conflicts between peers npm/arborist#266

Merged

mshima mentioned this issue Apr 27, 2021

Workaround eresolve by helping npm with webpack dependency. oktadev/ionic-jhipster-starter#52

Closed

nlf mentioned this issue Apr 27, 2021

support resolvable partial intersecting peerSets npm/arborist#272

Closed

princemaple mentioned this issue Apr 28, 2021

NPM 7.6 packages update fail angular/angular-cli#20180

Closed

15 tasks

alan-agius4 mentioned this issue Apr 28, 2021

Updating from 11.2.5 to 11.2.6 throws an error angular/angular-cli#20375

Closed

15 tasks

isaacs closed this as completed in npm/arborist@e4a5fd2 Apr 29, 2021

Heatmanofurioso mentioned this issue Apr 29, 2021

[BUG] npm install does not install actual version of dependency from package.json leaving outdated one there #3057

Closed

boris-jenicek mentioned this issue Oct 31, 2021

Unable to install boris-jenicek/ngx-awesome-popup#17

Closed

pIvan mentioned this issue Jun 7, 2022

Peer dep resolution pIvan/file-upload#70

Closed

szuperaz mentioned this issue Feb 16, 2023

Problems with Angular 12 and 13 GetStream/stream-chat-angular#410

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BUG] failed to resolve peer dependencies (conflict) when peer dependencies are in range. #3152

[BUG] failed to resolve peer dependencies (conflict) when peer dependencies are in range. #3152

talsi commented Apr 26, 2021

nlf commented Apr 26, 2021

talsi commented Apr 26, 2021

nlf commented Apr 26, 2021

princemaple commented May 2, 2021

talsi commented May 2, 2021

princemaple commented May 3, 2021

talsi commented Nov 8, 2021

talsi commented Nov 8, 2021

Quazmoz commented Feb 8, 2022

ljharb commented Feb 8, 2022

talsi commented Feb 9, 2022

ljharb commented Feb 9, 2022

talsi commented Feb 9, 2022

ljharb commented Feb 9, 2022

faizaldong commented Jun 8, 2022 •

edited

Loading

mshakibdev commented Jun 27, 2022

ljharb commented Jun 27, 2022

[BUG] failed to resolve peer dependencies (conflict) when peer dependencies are in range. #3152

[BUG] failed to resolve peer dependencies (conflict) when peer dependencies are in range. #3152

Comments

talsi commented Apr 26, 2021

Current Behavior:

Expected Behavior:

Steps To Reproduce:

Environment:

nlf commented Apr 26, 2021

talsi commented Apr 26, 2021

nlf commented Apr 26, 2021

princemaple commented May 2, 2021

talsi commented May 2, 2021

princemaple commented May 3, 2021

talsi commented Nov 8, 2021

talsi commented Nov 8, 2021

Quazmoz commented Feb 8, 2022

ljharb commented Feb 8, 2022

talsi commented Feb 9, 2022

ljharb commented Feb 9, 2022

talsi commented Feb 9, 2022

ljharb commented Feb 9, 2022

faizaldong commented Jun 8, 2022 • edited Loading

mshakibdev commented Jun 27, 2022

ljharb commented Jun 27, 2022

faizaldong commented Jun 8, 2022 •

edited

Loading