Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] npm ci changes package.json #1811

Closed
targos opened this issue Sep 16, 2020 · 1 comment
Closed

[BUG] npm ci changes package.json #1811

targos opened this issue Sep 16, 2020 · 1 comment
Labels
Bug thing that needs fixing Needs Triage needs review for next steps Release 7.x work is associated with a specific npm 7 release

Comments

@targos
Copy link
Contributor

targos commented Sep 16, 2020

Current Behavior:

Running npm ci updates the dependencies in package.json (key ordering).

Expected Behavior:

npm ci should either error or ignore the wrong ordering. I expect only npm install to modify files like package.json or package-lock.json.

Steps To Reproduce:

See https://github.com/targos/npm7-cra#issue-1-npm-ci-changes-packagejson

Environment:

  • OS: CentOS 8, Windows 10
  • Node: 14.11.0
  • npm: 7.0.0-beta.11 (note that this did not happen with v70.0-beta.10)
@targos targos added Bug thing that needs fixing Needs Triage needs review for next steps Release 7.x work is associated with a specific npm 7 release labels Sep 16, 2020
@isaacs
Copy link
Contributor

isaacs commented Sep 16, 2020

Fixed by 24f3a54

Sorry, didn't notice you'd posted issues, so the ref in the commit is pointing at your repro repo. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Needs Triage needs review for next steps Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Development

No branches or pull requests

2 participants