fix: workspace query bug

Fixes a query bug which omits some dependencies in scenarios where a
workspace has a dependency on another workspace in the project.

Signed-off-by: Brian DeHamer <bdehamer@github.com>

Author: bdehamer

workspaces/arborist/lib/query-selector-all.js

@@ -697,9 +697,20 @@ const hasParent = (node, compareNodes) => {
   // All it takes is one so we loop and return on the first hit
   for (const compareNode of compareNodes) {
     // follows logical parent for link anscestors
-    if (node.isTop && (node.resolveParent === compareNode)) {
-      return true
+    if (node.isTop) {
+      if (node.resolveParent === compareNode) {
+        return true
+      } else {
+        // Top-level nodes have no edgesIn, so check the edgesOut
+        // of the parent to see if any of them are links to this node
+        for (const edge of compareNode.edgesOut.values()) {
+          if (edge.to === node || edge.to?.target === node) {
+            return true
+          }
+        }
+      }
     }
+
     // follows edges-in to check if they match a possible parent
     for (const edge of node.edgesIn) {
       if (edge && edge.from === compareNode) {

workspaces/arborist/test/query-selector-all.js

@@ -24,6 +24,7 @@ t.test('query-selector-all', async t => {
     │   └── lorem@1.0.0 (production dep of baz)
     ├── abbrev@1.1.1 (production dep of query-selector-all-tests)
     ├─┬ b@1.0.0 -> ./b (workspace)
+    │ ├── a@2.0.0 (dev dep of b, deduped)
     │ └── bar@2.0.0 (production dep of b, deduped)
     ├─┬ bar@2.0.0 (production dep of query-selector-all-tests)
     │ └── moo@3.0.0 (production dep of bar)
@@ -513,7 +514,7 @@ t.test('query-selector-all', async t => {
     ['*:has(* > #bar:semver(1.4.0))', ['foo@2.2.2']],
     ['*:has(> #bar:semver(1.4.0))', ['foo@2.2.2']],
     ['.workspace:has(> * > #lorem)', ['a@1.0.0']],
-    ['.workspace:has(* #lorem, ~ #b)', ['a@1.0.0']],
+    ['.workspace:has(* #lorem, ~ #b)', ['a@1.0.0', 'b@1.0.0']],
 
     // is pseudo
     [':is(#a, #b) > *', ['a@1.0.0', 'bar@2.0.0', 'baz@1.0.0']],
@@ -960,5 +961,6 @@ t.test('query-selector-all', async t => {
     [':root #bar:semver(1) ~ *', ['dash-separated-pkg@1.0.0']],
     ['#bar:semver(2), #foo', ['bar@2.0.0', 'foo@2.2.2']],
     ['#a, #bar:semver(2), #foo:semver(2.2.2)', ['a@1.0.0', 'bar@2.0.0', 'foo@2.2.2']],
+    ['#b *', ['a@1.0.0', 'bar@2.0.0', 'baz@1.0.0', 'lorem@1.0.0', 'moo@3.0.0']],
   ])
 })