Skip to content

Commit 70f54dc

Browse files
gemalisaacs
authored andcommitted
Make OK more consistent
PR-URL: #241 Credit: @gemal Close: #241 Reviewed-by: @isaacs
1 parent f46edae commit 70f54dc

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

lib/doctor/check-ping.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ function checkPing (cb) {
88
if (err && err.code && err.code.match(/^E\d{3}$/)) {
99
return cb(null, [err.code.substr(1)])
1010
} else {
11-
cb(null, [200, 'OK'])
11+
cb(null, [200, 'ok'])
1212
}
1313
})
1414
}

test/tap/doctor.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ t.test('npm doctor', function (t) {
9292
npm.commands.doctor({'node-url': node_url}, true, function (e, list) {
9393
t.ifError(e, 'npm loaded successfully')
9494
t.same(list.length, 9, 'list should have 9 prop')
95-
t.same(list[0][1], 'OK', 'npm ping')
95+
t.same(list[0][1], 'ok', 'npm ping')
9696
t.same(list[1][1], 'v' + npm.version, 'npm -v')
9797
t.same(list[2][1], process.version, 'node -v')
9898
t.same(list[3][1], common.registry + '/', 'npm config get registry')
@@ -113,7 +113,7 @@ t.test('npm doctor works without registry', function (t) {
113113
npm.commands.doctor({'node-url': node_url}, true, function (e, list) {
114114
t.ifError(e, 'npm loaded successfully')
115115
t.same(list.length, 9, 'list should have 9 prop')
116-
t.same(list[0][1], 'OK', 'npm ping')
116+
t.same(list[0][1], 'ok', 'npm ping')
117117
t.same(list[1][1], 'v' + npm.version, 'npm -v')
118118
t.same(list[2][1], process.version, 'node -v')
119119
t.same(list[3][1], '', 'no registry, but no crash')

0 commit comments

Comments
 (0)