Skip to content

Commit

Permalink
change 'maxsockets' default value back to 15
Browse files Browse the repository at this point in the history
The default value for 'maxsockets' was changed during the refactoring
in #2878 from 50 to 'Inifinity', this PR changes it to the more
accurate value of 15, which was the default used in:
https://github.com/npm/make-fetch-happen/blob/785af652ec0c8f108a43004903afd2183af93904/agent.js#L15

Fixes #2978

PR-URL: #2979
Credit: @wallrat
Close: #2979
Reviewed-by: @ruyadorno

Co-authored-by: Gar <gar+gh@danger.computer>
  • Loading branch information
2 people authored and ruyadorno committed Mar 29, 2021
1 parent 9d39146 commit 4b10024
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion docs/content/using-npm/config.md
Original file line number Diff line number Diff line change
Expand Up @@ -795,7 +795,7 @@ Show extended information in `npm ls` and `npm search`.

#### `maxsockets`

* Default: Infinity
* Default: 15
* Type: Number

The maximum number of connections to use per origin (protocol/host/port
Expand Down
2 changes: 1 addition & 1 deletion lib/utils/config/definitions.js
Original file line number Diff line number Diff line change
Expand Up @@ -1154,7 +1154,7 @@ define('long', {
})

define('maxsockets', {
default: Infinity,
default: 15,
type: Number,
description: `
The maximum number of connections to use per origin (protocol/host/port
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -674,7 +674,7 @@ Show extended information in \`npm ls\` and \`npm search\`.
#### \`maxsockets\`
* Default: Infinity
* Default: 15
* Type: Number
The maximum number of connections to use per origin (protocol/host/port
Expand Down

0 comments on commit 4b10024

Please sign in to comment.