This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Properly track dev edges on virtual root nodes #214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacs
force-pushed
the
isaacs/maintain-dev-edge-on-root-virtual-node
branch
2 times, most recently
from
45fe2c9
to
51aa834
Compare
isaacs
force-pushed
the
isaacs/maintain-dev-edge-on-root-virtual-node
branch
from
51aa834
to
f5be3c4
Compare
If the virtualRoot node has a sourceReference, and that sourceReference node would get its devDep edges loaded, then the virtualRoot node should as well. This caused a very useless ERESOLVE error, which could not be properly forced away, when installing in a project that had conflicting peer deps in its dev tree. Related to: npm/cli#2548
isaacs
force-pushed
the
isaacs/maintain-dev-edge-on-root-virtual-node
branch
from
f5be3c4
to
683b5ac
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the virtualRoot node has a sourceReference, and that sourceReference
node would get its devDep edges loaded, then the virtualRoot node should
as well.
This caused a very useless ERESOLVE error, which could not be properly
forced away, when installing in a project that had conflicting peer deps
in its dev tree.
References