Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EquivalenceQuery expected results according to more refined output in optimized solution #95

Open
zivnevo opened this issue Aug 1, 2024 · 0 comments

Comments

@zivnevo
Copy link
Member

zivnevo commented Aug 1, 2024

See tests/istio_testcases/example_policies/bookinfo-demo/sidecar_examples/equivalence-with-sidecars-scheme.yaml:
In the original solution, the difference is as follows:
src: default/ratings-v1-1, dst: 0.0.0.0-255.255.255.255, description: sidecar-with-selector-allows-any allows all connections while sidecar-with-selector-registery-only does not
while in the optimized solution the difference is as follows:
src: default/ratings-v1-1, dst: 0.0.0.0-255.255.255.255, description: sidecar-with-selector-allows-any allows communication using protocol TCP while sidecar-with-selector-registery-only does not.

The difference is due to the exact calculation (and printing) of the difference in the optimized solution.
Until the expected result is updated (after completely moving to the optimized solution, see IBM/network-config-analyzer#495), expected result of this test is commented out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant