Skip to content

Commit 8df6a20

Browse files
yfeldblumfacebook-github-bot
authored andcommitted
remove time.h include from folly-config.h
Summary: `folly-config.h` included `time.h` in order to test for the `CLOCK_REALTIME` macro, which was a proxy to test for the `clock_gettime` function. This was for Apple platforms, which ages ago did not all export `clock_gettime`. But current and recent Apple platforms should all export it. Also cut `glibc-rt` and `liburing` deps from `folly:config`. The rule owning this header should depend on nothing. `autodeps` and `arc lint` breakage involving these deps originally reported by DenisYaroshevskiy in: https://fb.workplace.com/groups/560979627394613/posts/2913288488830370/. #buildall Reviewed By: spikeh Differential Revision: D56805126 fbshipit-source-id: 7894de40c6de234ef05e8754ae6a733987a15477
1 parent a9a82be commit 8df6a20

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

folly/BUCK

-10
Original file line numberDiff line numberDiff line change
@@ -223,16 +223,6 @@ cpp_library(
223223
cpp_library(
224224
name = "config",
225225
headers = ["folly-config.h"],
226-
os_deps = [(
227-
"linux",
228-
select({
229-
"DEFAULT": [],
230-
"ovr_config//runtime:fbcode": ["fbsource//third-party/liburing:uring"],
231-
}),
232-
)],
233-
exported_external_deps = [
234-
("glibc", None, "rt"),
235-
],
236226
)
237227

238228
cpp_library(

0 commit comments

Comments
 (0)