Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix escaping single quotation marks for guid on status page #275

Closed
wants to merge 1 commit into from

Conversation

Michsior14
Copy link

This resolves the problems with the download of movie release with single quotation marks in the title i.e. Ocean's 8.

@nosmokingbandit
Copy link
Owner

I'm not having any problems with that movie or any releases and my javascript console is clean. What problems did you observe?

@Michsior14
Copy link
Author

Michsior14 commented Oct 4, 2018

I am using Jackett for indexing and for the Ocean's 8 the download button in the template looks like this:
<button class="btn btn-sm btn-secondary w-100" title="Download" onclick="manual_download(event, this, 'http://localhost:9117/dl/yts/?jackett_apikey=API_KEY&amp;file=Ocean's+Eight+(2018)+720p+BRRip', 'torrent', 'tt5164214')"><i class="mdi mdi-download"></i></button>
The click on the button rises an error because of quotation in the value.
If the problem doesn't exist in other indexers I can have the look in TorzNab implementation :)

@nosmokingbandit
Copy link
Owner

nosmokingbandit commented Oct 4, 2018

Jackett shouldn't be putting un-encoded single quotes in the url to begin with. I'll address this in the backend where the jackett feed is parsed so the database has a proper url stored.

nosmokingbandit added a commit that referenced this pull request Oct 5, 2018
%-encode Torznab querystrings since Jackett doesn't.
@Michsior14
Copy link
Author

Cool, thanks 🙂

@Michsior14 Michsior14 closed this Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants