Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify IInstallationService interface #7439

Open
skoshelev opened this issue Dec 3, 2024 · 0 comments
Open

Simplify IInstallationService interface #7439

skoshelev opened this issue Dec 3, 2024 · 0 comments

Comments

@skoshelev
Copy link
Contributor

There is no big point in keeping two methods InstallRequiredData and InstallSampleData in this interface. Instead, we can create one method InstallAsync with the fillSampleData parameter, indicating whether we need to install test data.
This will not only help simplify the interface but also make the code cleaner, for example, it will allow you not to insert the DisplayDefaultMenuItemSettings settings twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants