fix(taskflow): set taskflow name when initialize a new object#77
Merged
noneback merged 2 commits intononeback:mainfrom Apr 7, 2025
Merged
fix(taskflow): set taskflow name when initialize a new object#77noneback merged 2 commits intononeback:mainfrom
noneback merged 2 commits intononeback:mainfrom
Conversation
noneback
reviewed
Apr 6, 2025
taskflow.go
Outdated
| // NewTaskFlow returns a taskflow struct | ||
| func NewTaskFlow(name string) *TaskFlow { | ||
| return &TaskFlow{ | ||
| name: name, |
Owner
There was a problem hiding this comment.
You can just remove the name attribute of Taskflow struct if it is unused
Contributor
Author
There was a problem hiding this comment.
well i think this is a useful attribute, I meet the situation that I need to use taskflow name when I write programs, so I recommend to keep it rather than just removing it
LinPr
changed the title
Owner
|
I suggest we use one commit at a time if pr is simple. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #77 +/- ##
=======================================
Coverage 86.75% 86.75%
=======================================
Files 13 13
Lines 717 717
=======================================
Hits 622 622
Misses 73 73
Partials 22 22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.