Skip to content

fix(example): repair simple example codes cause panic#73

Merged
noneback merged 1 commit intononeback:mainfrom
LinPr:fix-simple
Apr 7, 2025
Merged

fix(example): repair simple example codes cause panic#73
noneback merged 1 commit intononeback:mainfrom
LinPr:fix-simple

Conversation

@LinPr
Copy link
Contributor

@LinPr LinPr commented Mar 31, 2025

Issue: #72
I found the error in /example/simple.go and fix the codes that cause panic , and made this PR

@noneback
Copy link
Owner

noneback commented Apr 6, 2025

Thanks for fixing it.

Can you change the commit message style? We should have a coherent way of using commit messages.

@codecov
Copy link

codecov bot commented Apr 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.75%. Comparing base (67b2e67) to head (c58bbf5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #73   +/-   ##
=======================================
  Coverage   86.75%   86.75%           
=======================================
  Files          13       13           
  Lines         717      717           
=======================================
  Hits          622      622           
  Misses         73       73           
  Partials       22       22           
Flag Coverage Δ
unittests 86.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LinPr
Copy link
Contributor Author

LinPr commented Apr 6, 2025

Thanks for fixing it.

Can you change the commit message style? We should have a coherent way of using commit messages.

Okay I will do it soon,thanks for replying

@LinPr LinPr changed the title fix: repair the codes cause panic fix(example): repair the codes cause panic Apr 6, 2025
@noneback
Copy link
Owner

noneback commented Apr 7, 2025

Please verify your signature. Try git commit -S -m "YOUR_COMMIT_MESSAGE"

@noneback noneback requested a review from Copilot April 7, 2025 02:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@LinPr LinPr changed the title fix(example): repair the codes cause panic fix(example): repair simple example codes cause panic Apr 7, 2025
@noneback noneback merged commit 48799e0 into noneback:main Apr 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants