Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cards effect not support RTL #5534

Closed
5 of 6 tasks
efraimKroizer opened this issue Mar 9, 2022 · 3 comments
Closed
5 of 6 tasks

cards effect not support RTL #5534

efraimKroizer opened this issue Mar 9, 2022 · 3 comments

Comments

@efraimKroizer
Copy link

efraimKroizer commented Mar 9, 2022

Check that this is really a bug

  • I confirm

Reproduction link

https://jsfiddle.net/0ywsmxf5/1/

Bug description

when a swiper with cards effect shown on rtl, not the direction of next/prev slides is correct, and the swipe behavior is opposite the swipe direction.
i try to fix it in source code, with edit this row in effect-dards.js file

const progress = Math.min(Math.max(slideProgress, -4), 4) * (rtl ? -1 : 1);

it help for direction of slides and to swipe direction, but the behavior of the prev/next slides z-index and scaling is not consistently.

Expected Behavior

No response

Actual Behavior

No response

Swiper version

8.0.7

Platform/Target and Browser Versions

windows chrome

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
  • Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

  • I'm willing to open a PR
@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 21, 2022
@dangelion
Copy link

Please is there a solution to this?

@stale stale bot removed the stale label May 17, 2023
@efraim-icreate
Copy link

thanks for your fixing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants