Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloned slide should be tabindex="-1" and aria-hidden="true" when loop="true" #2929

Closed
3 tasks done
mrleblanc101 opened this issue Dec 21, 2018 · 2 comments
Closed
3 tasks done
Labels

Comments

@mrleblanc101
Copy link

This is a (multiple allowed):

  • bug

  • enhancement

  • feature-discussion (RFC)

  • Swiper Version: 4.0.7

  • Platform/Target and Browser Versions: macOS, iOS, Windows, Chrome, Firefox, Safari, IE11, Edge

What you did

For a11y reason, i added tabindex="0" so screenreader would read my slide content.
Sadly, when swiper 4 clone the slide it also clone those attr.
Cloned slide should always be hidden to screen reader.
Also it would be nice to disabled autoplay on slide focus natively, I was able to fix this but it really should be build-it.

Expected Behavior

Cloned slide should always have tabindex="-1" and aria-hidden="true"

Actual Behavior

Cloned slide have tabindex="0" and no aria-hidden value

@stale
Copy link

stale bot commented Sep 30, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 30, 2019
@stale
Copy link

stale bot commented Nov 29, 2019

This issue has been automatically closed due to inactivity. If this issue is still actual, please, create the new one.

@stale stale bot closed this as completed Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant