Skip to content

Commit

Permalink
feat: remove Images loading functionality: preloadImages, updateOnIma…
Browse files Browse the repository at this point in the history
…gesReady
  • Loading branch information
nolimits4web committed Nov 10, 2022
1 parent 842f82f commit 4d02653
Show file tree
Hide file tree
Showing 9 changed files with 1 addition and 104 deletions.
2 changes: 0 additions & 2 deletions src/components-shared/params-list.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,6 @@ const paramsList = [
'preventClicks',
'preventClicksPropagation',
'_slideToClickedSlide',
'_preloadImages',
'updateOnImagesReady',
'_loop',
'_loopAdditionalSlides',
'_loopedSlides',
Expand Down
6 changes: 0 additions & 6 deletions src/core/core.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import grabCursor from './grab-cursor/index.js';
import events from './events/index.js';
import breakpoints from './breakpoints/index.js';
import classes from './classes/index.js';
import images from './images/index.js';
import checkOverflow from './check-overflow/index.js';

import defaults from './defaults.js';
Expand All @@ -38,7 +37,6 @@ const prototypes = {
breakpoints,
checkOverflow,
classes,
images,
};

const extendedDefaults = {};
Expand Down Expand Up @@ -547,10 +545,6 @@ class Swiper {
swiper.setGrabCursor();
}

if (swiper.params.preloadImages) {
swiper.preloadImages();
}

// Slide To Initial Slide
if (swiper.params.loop) {
swiper.slideTo(
Expand Down
4 changes: 0 additions & 4 deletions src/core/defaults.js
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,6 @@ export default {
preventClicksPropagation: true,
slideToClickedSlide: false,

// Images
preloadImages: true,
updateOnImagesReady: true,

// loop
loop: false,
loopAdditionalSlides: 0,
Expand Down
7 changes: 0 additions & 7 deletions src/core/images/index.js

This file was deleted.

33 changes: 0 additions & 33 deletions src/core/images/loadImage.js

This file was deleted.

23 changes: 0 additions & 23 deletions src/core/images/preloadImages.js

This file was deleted.

5 changes: 0 additions & 5 deletions src/types/swiper-events.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -149,11 +149,6 @@ export interface SwiperEvents {
*/
doubleTap: (swiper: Swiper, event: MouseEvent | TouchEvent | PointerEvent) => void;

/**
* Event will be fired right after all inner images are loaded. updateOnImagesReady should be also enabled
*/
imagesReady: (swiper: Swiper) => void;

/**
* Event will be fired when Swiper progress is changed, as an arguments it receives progress that is always from 0 to 1
*/
Expand Down
17 changes: 1 addition & 16 deletions src/types/swiper-options.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -579,21 +579,6 @@ export interface SwiperOptions {
*/
watchSlidesProgress?: boolean;

// Images
/**
* When enabled Swiper will force to load all images
*
* @default true
*/
preloadImages?: boolean;

/**
* When enabled Swiper will be reinitialized after all inner images (<img> tags) are loaded. Required `preloadImages: true`
*
* @default true
*/
updateOnImagesReady?: boolean;

/**
* Set to `true` to enable continuous loop mode
*
Expand Down Expand Up @@ -1069,7 +1054,7 @@ export interface SwiperOptions {
* ```js
* const swiper = new Swiper('.swiper', {
* lazy: {
* loadPrevNext: true,
* preloaderClass: 'swiper-lazy-preloader',
* },
* });
* ```
Expand Down
8 changes: 0 additions & 8 deletions src/vue/swiper-vue.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -248,14 +248,6 @@ declare const Swiper: DefineComponent<
type: BooleanConstructor;
default: undefined;
};
preloadImages: {
type: BooleanConstructor;
default: undefined;
};
updateOnImagesReady: {
type: BooleanConstructor;
default: undefined;
};
loop: { type: BooleanConstructor; default: undefined };
loopAdditionalSlides: {
type: NumberConstructor;
Expand Down

0 comments on commit 4d02653

Please sign in to comment.