Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Fix the detection of field deletion in diffs #70

Closed
kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Closed

[PR] Fix the detection of field deletion in diffs #70

kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Labels
archive automation CI/CD: testing, linting, releasing automatically bug Something isn't working

Comments

@kopf-archiver
Copy link

kopf-archiver bot commented Aug 18, 2020

A pull request by nolar at 2019-05-22 14:19:03+00:00
Original URL: zalando-incubator/kopf#70
Merged by nolar at 2019-05-23 23:24:12+00:00

Issue : #13

As accidentally detected during #69 — this fixes a little issue with KeyError raised when the field is removed from the object, and a field-handler is called for that event, and fails to "resolve" the old/new value for the field-handler (i.e. a subset of a bigger diff-object), as the field is not in one of those per-object old/new structs.

@kopf-archiver kopf-archiver bot closed this as completed Aug 18, 2020
@kopf-archiver kopf-archiver bot changed the title [archival placeholder] [PR] Fix the detection of field deletion in diffs Aug 19, 2020
@kopf-archiver kopf-archiver bot added automation CI/CD: testing, linting, releasing automatically bug Something isn't working labels Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archive automation CI/CD: testing, linting, releasing automatically bug Something isn't working
Projects
None yet
Development

No branches or pull requests

0 participants