Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include Promise polyfill in library #17

Closed
dariocravero opened this issue Feb 14, 2017 · 2 comments
Closed

Don't include Promise polyfill in library #17

dariocravero opened this issue Feb 14, 2017 · 2 comments

Comments

@dariocravero
Copy link

Hi @nolanlawson, I hope you're well :). I was wondering if you'd consider a PR removing lie and asking library authors to polyfill Promise instead if they still want to support older browsers and inlining is-promise to reduce the overhead caused by browserify when bundling it? Thanks, Darío

@nolanlawson
Copy link
Owner

nolanlawson commented Feb 17, 2017

Hey sorry, but I'm kind of loath to offer this kind of option for every library I use that exposes Promises... currently you can remove lie very trivially by doing e.g.:

browserify -r promise-worker -x lie

However this was discussed recently in a generic way (w3ctag/polyfills#6) and so I have hopes that at some point bundlers like webpack and browserify may offer a generic solution to this problem.

As for is-promise, yeah I would accept a PR inlining it because it's silly to have a single dependency in the worker file. :)

@dariocravero
Copy link
Author

Thanks for the link, that's an amazing conversation there ;). Will get to this sometime next week and do that little PR too. I'll leave this open as a reminder for myself mainly if that's alright. Thanks :)

@nolanlawson nolanlawson changed the title Question on dependencies Don't include Promise polyfill in library May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants