-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report remaining chars #2300
Report remaining chars #2300
Conversation
Fixes issue #2267 |
} else { | ||
return formatIntl('intl.underLimit', { count: lengthToDisplayDeferred }) | ||
return 'polite' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that intl.overLimit
and intl.underLimit
are unused, we can remove them from en-US.js
(and the other intl files in the same directory).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See question above, otherwise LGTM
Thanks @nolanlawson. Several times I had to rewrite a toot since I exceeded the limit of characters and this may help a lot when we type a long message |
Co-authored-by: Nolan Lawson <nolan@nolanlawson.com>
No description provided.