Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report remaining chars #2300

Merged
merged 5 commits into from
Dec 10, 2022
Merged

Conversation

nvdaes
Copy link
Contributor

@nvdaes nvdaes commented Dec 5, 2022

No description provided.

@nvdaes
Copy link
Contributor Author

nvdaes commented Dec 5, 2022

Fixes issue #2267

} else {
return formatIntl('intl.underLimit', { count: lengthToDisplayDeferred })
return 'polite'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that intl.overLimit and intl.underLimit are unused, we can remove them from en-US.js (and the other intl files in the same directory).

Copy link
Owner

@nolanlawson nolanlawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See question above, otherwise LGTM

@nvdaes
Copy link
Contributor Author

nvdaes commented Dec 9, 2022

Thanks @nolanlawson. Several times I had to rewrite a toot since I exceeded the limit of characters and this may help a lot when we type a long message

@nvdaes nvdaes mentioned this pull request Dec 10, 2022
@nolanlawson nolanlawson merged commit 4a6907b into nolanlawson:master Dec 10, 2022
alice-werefox pushed a commit to alice-werefox/sema-werefox-cafe that referenced this pull request Apr 3, 2023
Co-authored-by: Nolan Lawson <nolan@nolanlawson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants