-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation into Spanish #2281
Translation into Spanish #2281
Conversation
Thanks a lot! Just so you're aware, translations do not really work yet, unless you're willing to host Pinafore yourself: https://github.com/nolanlawson/pinafore/blob/master/docs/Internationalization.md |
Thanks for your interest. The translation may take some time. If I cannot host Pinafore, maybe done by others or you may request help to host different languages, for example with donations. Let's see how thingsgo. |
Totally understandable. To be honest, I have not had the time to do translations properly, which is why it's in the state it's in. I just wanted to let you know before you put in a bunch of effort to translate the whole thing. 🙂 |
I've finished this. If something needs to be improved, I'll try to do it when I use this seeing the whole context in real life, though I've read the comments of the different sections and they are helpful. |
Awesome, thanks! I don't know when/if we'll get internationalization actually working in Pinafore, but I appreciate the effort. 🙂 |
A person mentioned that may host Pinafores translated into Spanish in a server. I know that emojis aren"t translated, but for now this is my work. BTW, for me is more accessible to use Pinafore"s emojis picker than the emojis panel on Windows while using Pinafore, with Nvda screen reader. Thank you.
Enviado desde mi iPhone
… El 11 dic 2022, a las 0:24, Nolan Lawson ***@***.***> escribió:
Awesome, thanks! I don't know when/if we'll get internationalization actually working in Pinafore, but I appreciate the effort. 🙂
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
Emojis are actually translated, I can't recall if Pinafore correctly hooks into this functionality though. |
Did not mean to close. |
Ok, I think that emojis can be translated but that they aren"t translated yet. Thanks.
Enviado desde mi iPhone
… El 11 dic 2022, a las 0:42, Nolan Lawson ***@***.***> escribió:
Emojis are actually translated, emoji-picker-element supports it: https://github.com/nolanlawson/emoji-picker-element/#internationalization
I can't recall if Pinafore correctly hooks into this functionality though.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
Meant I thought emojis need to be translated. Just a spanish speaker typing fast and using present instead of past in a verb. |
Yes, this applies to the title/aria-label on emojis too. We get them from |
I've fixed errors and translated new messages included in /src/intl/en-US.js |
Here, this fixes the Spanish locale for the emoji picker: e335441 I'm happy to merge this, please feel free to host your own Spanish version of Pinafore. Thanks for the effort! |
Thank you. Feel free to merge this when you want. If I detect some to improve, I"ll do after the next release. We"ll thinking about host this in Spanish, maybe on GitHub Pages or Vercel, so Ill inform that this is approved to see if we register a domain for this.
Enviado desde mi iPhone
… El 17 dic 2022, a las 18:11, Nolan Lawson ***@***.***> escribió:
@nolanlawson approved this pull request.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
Co-authored-by: Nolan Lawson <nolan@nolanlawson.com> Co-authored-by: Noelia Ruiz Martínez <n4m1977@gmail.com>
No description provided.