Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation into Spanish #2281

Merged
merged 21 commits into from
Dec 17, 2022
Merged

Translation into Spanish #2281

merged 21 commits into from
Dec 17, 2022

Conversation

nvdaes
Copy link
Contributor

@nvdaes nvdaes commented Nov 30, 2022

No description provided.

@nolanlawson
Copy link
Owner

Thanks a lot! Just so you're aware, translations do not really work yet, unless you're willing to host Pinafore yourself: https://github.com/nolanlawson/pinafore/blob/master/docs/Internationalization.md

@nvdaes
Copy link
Contributor Author

nvdaes commented Dec 3, 2022

Thanks for your interest. The translation may take some time. If I cannot host Pinafore, maybe done by others or you may request help to host different languages, for example with donations. Let's see how thingsgo.

@nolanlawson
Copy link
Owner

Totally understandable. To be honest, I have not had the time to do translations properly, which is why it's in the state it's in. I just wanted to let you know before you put in a bunch of effort to translate the whole thing. 🙂

@nvdaes
Copy link
Contributor Author

nvdaes commented Dec 10, 2022

I've finished this. If something needs to be improved, I'll try to do it when I use this seeing the whole context in real life, though I've read the comments of the different sections and they are helpful.
We'll need to remove some strings when PR #2300 is merged.

@nolanlawson
Copy link
Owner

Awesome, thanks! I don't know when/if we'll get internationalization actually working in Pinafore, but I appreciate the effort. 🙂

@nvdaes
Copy link
Contributor Author

nvdaes commented Dec 10, 2022 via email

@nolanlawson
Copy link
Owner

Emojis are actually translated, emoji-picker-element supports it: https://github.com/nolanlawson/emoji-picker-element/#internationalization

I can't recall if Pinafore correctly hooks into this functionality though.

@nolanlawson
Copy link
Owner

Did not mean to close.

@nolanlawson nolanlawson reopened this Dec 10, 2022
@nvdaes
Copy link
Contributor Author

nvdaes commented Dec 10, 2022 via email

@nvdaes
Copy link
Contributor Author

nvdaes commented Dec 10, 2022

Meant I thought emojis need to be translated. Just a spanish speaker typing fast and using present instead of past in a verb.

@nolanlawson
Copy link
Owner

Yes, this applies to the title/aria-label on emojis too. We get them from emoji-picker-element's database.

@nvdaes
Copy link
Contributor Author

nvdaes commented Dec 13, 2022

I've fixed errors and translated new messages included in /src/intl/en-US.js
Now all checks pass. @nolanlawson , if you want, we can wait to see if more messages have to be translated for the next release and then you may merge this.
We're talking in a spanish mailing list about the possibility to host bPinafore in Spanish and we'll be testing this translation locally in dev mode.

@nolanlawson
Copy link
Owner

Here, this fixes the Spanish locale for the emoji picker: e335441

I'm happy to merge this, please feel free to host your own Spanish version of Pinafore. Thanks for the effort!

@nvdaes
Copy link
Contributor Author

nvdaes commented Dec 17, 2022 via email

@nolanlawson nolanlawson merged commit d71430f into nolanlawson:master Dec 17, 2022
alice-werefox pushed a commit to alice-werefox/sema-werefox-cafe that referenced this pull request Apr 3, 2023
Co-authored-by: Nolan Lawson <nolan@nolanlawson.com>
Co-authored-by: Noelia Ruiz Martínez <n4m1977@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants