src: cleanup the RunCommand queues on RemoveEnv #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

santigimeno merged 4 commits into node-v20.x-nsolid-v5.x from santi/fix_shared_envinst_leak

Nov 22, 2023

Member

santigimeno commented Nov 16, 2023 •

edited

Loading

src: change EnvList::promise_tracking_() signature

Pass directly the SharedEnvInst.

src: fix EnvInst::GetCurrent()

Handle the case where the `Environment` is already nullptr.

src: cleanup the RunCommand queues on RemoveEnv

Just to be sure no dangling SharedEnvInst references are left after the
Environment is gone and the EnvInst instance can be deleted.

src: fix SetupArrayBufferExports() declaration

Fixes: #26

santigimeno requested a review from trevnorris

November 16, 2023 14:03

santigimeno self-assigned this

trevnorris approved these changes

View reviewed changes

santigimeno added 4 commits

November 22, 2023 15:24


          src: change EnvList::promise_tracking_() signature

209112a

Pass directly the SharedEnvInst.

PR-URL: #25
Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>


          src: fix EnvInst::GetCurrent()

6f303c7

Handle the case where the `Environment` is already nullptr.

PR-URL: #25
Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>


          src: cleanup the RunCommand queues on RemoveEnv

be6aea6

Just to be sure no dangling SharedEnvInst references are left after the
Environment is gone and the EnvInst instance can be deleted.

PR-URL: #25
Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>


          src: fix SetupArrayBufferExports() declaration

f16e228

PR-URL: #25
Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>

santigimeno force-pushed the santi/fix_shared_envinst_leak branch from 03690a8 to f16e228 Compare

November 22, 2023 14:24

santigimeno merged commit f16e228 into node-v20.x-nsolid-v5.x

santigimeno deleted the santi/fix_shared_envinst_leak branch

November 22, 2023 14:25

trevnorris pushed a commit that referenced this pull request


          src: change EnvList::promise_tracking_() signature

1f2366e

Pass directly the SharedEnvInst.

PR-URL: #25
Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>

trevnorris pushed a commit that referenced this pull request


          src: fix EnvInst::GetCurrent()

d67a0ba

Handle the case where the `Environment` is already nullptr.

PR-URL: #25
Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>

trevnorris pushed a commit that referenced this pull request


          src: cleanup the RunCommand queues on RemoveEnv

5e1b2d9

Just to be sure no dangling SharedEnvInst references are left after the
Environment is gone and the EnvInst instance can be deleted.

PR-URL: #25
Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>

trevnorris pushed a commit that referenced this pull request


          src: fix SetupArrayBufferExports() declaration

7e71090

PR-URL: #25
Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>

trevnorris pushed a commit that referenced this pull request


          src: change EnvList::promise_tracking_() signature

33c8b29

Pass directly the SharedEnvInst.

PR-URL: #25
Reviewed-by: Trevor Norris <trev.norris@gmail.com>

trevnorris pushed a commit that referenced this pull request


          src: fix EnvInst::GetCurrent()

2e55267

Handle the case where the `Environment` is already nullptr.

PR-URL: #25
Reviewed-by: Trevor Norris <trev.norris@gmail.com>

trevnorris pushed a commit that referenced this pull request


          src: cleanup the RunCommand queues on RemoveEnv

ed78fc6

Just to be sure no dangling SharedEnvInst references are left after the
Environment is gone and the EnvInst instance can be deleted.

PR-URL: #25
Reviewed-by: Trevor Norris <trev.norris@gmail.com>

trevnorris pushed a commit that referenced this pull request


          src: fix SetupArrayBufferExports() declaration

f6fd580

PR-URL: #25
Reviewed-by: Trevor Norris <trev.norris@gmail.com>

trevnorris pushed a commit that referenced this pull request


          src: change EnvList::promise_tracking_() signature

f2fc8ef

Pass directly the SharedEnvInst.

PR-URL: #25
Reviewed-by: Trevor Norris <trev.norris@gmail.com>

trevnorris pushed a commit that referenced this pull request


          src: fix EnvInst::GetCurrent()

7649d47

Handle the case where the `Environment` is already nullptr.

PR-URL: #25
Reviewed-by: Trevor Norris <trev.norris@gmail.com>

trevnorris pushed a commit that referenced this pull request


          src: cleanup the RunCommand queues on RemoveEnv

21fc1e9

Just to be sure no dangling SharedEnvInst references are left after the
Environment is gone and the EnvInst instance can be deleted.

PR-URL: #25
Reviewed-by: Trevor Norris <trev.norris@gmail.com>

trevnorris pushed a commit that referenced this pull request


          src: fix SetupArrayBufferExports() declaration

f4d4d46

PR-URL: #25
Reviewed-by: Trevor Norris <trev.norris@gmail.com>

juanarbol mentioned this pull request

2023-12-06, N|Solid v5.0.1 Iron Release #41

Merged

trevnorris pushed a commit that referenced this pull request


          src: change EnvList::promise_tracking_() signature

2d187ff

Pass directly the SharedEnvInst.

PR-URL: #25
Reviewed-by: Trevor Norris <trev.norris@gmail.com>

trevnorris pushed a commit that referenced this pull request


          src: fix EnvInst::GetCurrent()

5ab8629

Handle the case where the `Environment` is already nullptr.

PR-URL: #25
Reviewed-by: Trevor Norris <trev.norris@gmail.com>

trevnorris pushed a commit that referenced this pull request


          src: cleanup the RunCommand queues on RemoveEnv

2dbb826

Just to be sure no dangling SharedEnvInst references are left after the
Environment is gone and the EnvInst instance can be deleted.

PR-URL: #25
Reviewed-by: Trevor Norris <trev.norris@gmail.com>

trevnorris pushed a commit that referenced this pull request


          src: fix SetupArrayBufferExports() declaration

846637d

PR-URL: #25
Reviewed-by: Trevor Norris <trev.norris@gmail.com>

juanarbol mentioned this pull request

2023-12-07, N|Solid v5.0.1 Hydrogen Release #42

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet