fix: ensure that including dist/opossum.js works #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The node-specific webpack configuration was overwriting the config for the browser. Thus the distribution had a non-browser capable implementation that required some work on the user's part to get working in the browser. The user's webpack.config required an external declaration for `prom-client`. For example: lance/elizabethan-insults@ebabdf3#diff-23fce1009af5652674e09470cda3c008R9
helio-frota
approved these changes
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node-specific webpack configuration was overwriting the
config for the browser. Thus the distribution had a non-browser
capable implementation that required some work on the user's
part to get working in the browser. The user's webpack.config
required an external declaration for
prom-client. For example:lance/elizabethan-insults@ebabdf3#diff-23fce1009af5652674e09470cda3c008R9
Fixes: #338