Conversation
uv_fs_fstat() fails on TTYs on Windows. This commit updates uvwasi__get_filetype_by_fd() to detect this case and map the fd to the WASI character device type. Refs: nodejs/node#31461
tniessen
approved these changes
Jan 24, 2020
Member
tniessen
left a comment
tniessen
left a comment
There was a problem hiding this comment.
Should that only happen on Windows?
Collaborator
Author
|
I believe it should be Windows only. |
Member
Oh, yes, I assume it is Windows only, too. My question was more aimed at: Should this be guarded by |
Collaborator
Author
|
Oh I see what you mean. My thought was that it seems to be necessary on Windows, but for all other platforms it shouldn't do any harm. In this scenario, we're going to return an error, and making one last attempt at figuring out the file type. That said, if someone PR'ed an |
This was referenced Mar 14, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uv_fs_fstat()fails on TTYs on Windows. This commit updatesuvwasi__get_filetype_by_fd()to detect this case and map the fd to the WASI character device type.Refs: nodejs/node#31461