Skip to content

fix: android build #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 22, 2023
Merged

fix: android build #189

merged 2 commits into from
Feb 22, 2023

Conversation

gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Feb 20, 2023 •
edited
Loading

fix #188

@gengjiawen gengjiawen requested a review from cjihrig February 20, 2023 14:26
cjihrig
cjihrig approved these changes Feb 20, 2023
View reviewed changes
Copy link
Collaborator

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cjihrig cjihrig mentioned this pull request Feb 20, 2023
Merged
@cjihrig cjihrig merged commit 370cb05 into nodejs:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phated phated phated approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Android build is failing
3 participants
@gengjiawen @phated @cjihrig